Page MenuHomePhabricator

Add an id to editSummaryLabel div (Save panel)
Closed, InvalidPublic

Description

While the wikitext editor summary label has an id ("wpSummaryLabel"), the VisualEditor doesn't.
This is preventing the gadget ResumeDeluxe (source code) hook from working.
This gadget is doing the kind of thing intended by T54859, on both the wikitext editor and the VisualEditor.

Adding a "wpSummaryLabel" id (same one as for the wikitext editor) to that div would fix it, however it may be better to use something like "wpVESummaryLabel" to differentiate it.

The editSummaryLabel div code is located at https://phabricator.wikimedia.org/diffusion/EVED/browse/master/modules/ve-mw/ui/dialogs/ve.ui.MWSaveDialog.js;c707ab02b4ff32fff6313af3bec0437f0a67f8dd$305

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptNov 23 2016, 8:35 AM

You don't need an ID to select UI components, see https://en.wikipedia.org/wiki/MediaWiki:Gadget-defaultsummaries.js

I think in this case you want ve.init.target.saveDialog.$editSummaryLabel

The_RedBurn closed this task as Invalid.Nov 24 2016, 11:27 AM

Thanks, it works great!