Page MenuHomePhabricator
Create Task
Maniphest T151509

Gallery dialog's search results aspect ratio is different to the media dialog's search results
Closed, ResolvedPublic1 Estimated Story Points
Actions

Description

Steps to reproduce:

  1. Go to Gallery
  2. Observe that for some of the images under search results, there is an extra white border on top of it/below it.
  3. Go to Insert>Media
  4. Observe the difference.

For the same search results, it appears differently for Media search.

Gallery:

Screen Shot 2016-11-23 at 4.05.47 PM.png (727×560 px, 642 KB)

Media :
Screen Shot 2016-11-23 at 4.05.33 PM.png (889×627 px, 751 KB)

Details

Related Changes in Gerrit:
SubjectAuthorRepoBranchLines +/-
Decrease height of gallery search results for better fitTchandersmediawiki/extensions/VisualEditormaster+3 -1
Customize query in gerrit

Event Timeline

Ryasmeen created this task.Nov 24 2016, 12:16 AM
Herald added a subscriber: Aklapper. · View Herald TranscriptNov 24 2016, 12:16 AM
Jdforrester-WMF renamed this task from In Gallery, some images under search results are appearing with an extra white border around it to Gallery dialog's search results aspect ratio is different to the media dialog's search results.Nov 29 2016, 1:05 AM
Jdforrester-WMF triaged this task as Low priority.
Jdforrester-WMF added projects: MediaWiki-Gallery, VisualEditor-MediaWiki-Media.
Jdforrester-WMF set the point value for this task to 1.
Jdforrester-WMF moved this task from To Triage to Blocked on the VisualEditor board.
Tchanders subscribed.Dec 3 2016, 4:29 PM

I think this is because the space in the gallery dialog is narrower. After playing around a bit, setting a smaller row height seems to increase the probability of the images fitting better...

gerritbot subscribed.Dec 3 2016, 4:39 PM

Change 325108 had a related patch set uploaded (by Tchanders):
Decrease height of gallery search results for better fit

https://gerrit.wikimedia.org/r/325108

gerritbot added a project: Patch-For-Review.Dec 3 2016, 4:39 PM
Jdforrester-WMF closed this task as Resolved.Dec 6 2016, 6:21 PM
Jdforrester-WMF assigned this task to Tchanders.
Jdforrester-WMF removed a project: Patch-For-Review.
gerritbot added a comment.Dec 6 2016, 6:23 PM

Change 325108 merged by jenkins-bot:
Decrease height of gallery search results for better fit

https://gerrit.wikimedia.org/r/325108

ReleaseTaggerBot added a project: MW-1.29-release (WMF-deploy-2016-12-13_(1.29.0-wmf.6)).Dec 6 2016, 7:00 PM
Jdforrester-WMF edited projects, added: MW-1.29-release (WMF-deploy-2016-12-06_(1.29.0-wmf.5)); removed: MW-1.29-release (WMF-deploy-2016-12-13_(1.29.0-wmf.6)).Dec 6 2016, 7:29 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits