Page MenuHomePhabricator

Gallery dialog's search results aspect ratio is different to the media dialog's search results
Closed, ResolvedPublic1 Estimated Story Points

Description

Steps to reproduce:

  1. Go to Gallery
  2. Observe that for some of the images under search results, there is an extra white border on top of it/below it.
  3. Go to Insert>Media
  4. Observe the difference.

For the same search results, it appears differently for Media search.

Gallery:


Media :

Event Timeline

Jdforrester-WMF renamed this task from In Gallery, some images under search results are appearing with an extra white border around it to Gallery dialog's search results aspect ratio is different to the media dialog's search results.Nov 29 2016, 1:05 AM
Jdforrester-WMF triaged this task as Low priority.
Jdforrester-WMF set the point value for this task to 1.
Jdforrester-WMF moved this task from To Triage to Blocked on the VisualEditor board.

I think this is because the space in the gallery dialog is narrower. After playing around a bit, setting a smaller row height seems to increase the probability of the images fitting better...

Change 325108 had a related patch set uploaded (by Tchanders):
Decrease height of gallery search results for better fit

https://gerrit.wikimedia.org/r/325108

Change 325108 merged by jenkins-bot:
Decrease height of gallery search results for better fit

https://gerrit.wikimedia.org/r/325108