Move optional resource loader registration from PHP code to extension.json when it supports it
Closed, DuplicatePublic
Actions

Description

Some extensions register additional resource loader modules when VisualEditor is installed. The MediaWiki extension registry system does not support optional/conditional registrations yet, hence that has been done via the hook ResourceLoaderRegisterModules.

https://gerrit.wikimedia.org/r/#/c/316508/ is a proposal that will eventually add conditional registration in extension.json , once done we should migrate extensions that are using plain PHP, non exhaustive list:

Extension	Change
Cite	https://gerrit.wikimedia.org/r/#/c/316010/
GuidedTour	https://gerrit.wikimedia.org/r/#/c/305691/
SyntaxHighlight_GeSHi	https://gerrit.wikimedia.org/r/#/c/333580/

Details

	Project	Branch	Lines +/-	Subject
	mediawiki/extensions/Cite	master	+88 -114	Revert "Skip registering RL modules depending on VisualEditor"

Customize query in gerrit

Event Timeline

hashar created this task.Nov 24 2016, 8:13 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptNov 24 2016, 8:13 AM

hashar added a subtask: T128012: Support listing modules in extension.json that are registered if another extension is installed.Nov 24 2016, 8:13 AM

Change 323356 had a related patch set uploaded (by Hashar):
Revert "Skip registering RL modules depending on VisualEditor"

https://gerrit.wikimedia.org/r/323356

gerritbot added a project: Patch-For-Review.Nov 24 2016, 8:16 AM

Izno moved this task from Unsorted backlog to Enhancement backlog on the Cite board.Nov 29 2016, 9:36 PM

Jdforrester-WMF moved this task from Backlog to In Progress on the MediaWiki-Configuration board.Nov 30 2016, 11:13 PM

I have proposed a similar hack for SyntaxHighlight_GeSHi: https://gerrit.wikimedia.org/r/333580 Skip registering RL modules depending on VisualEditor.

I have added it to this task description.

TheDJ added a subscriber: TheDJ.Jan 23 2017, 11:01 AM

hashar triaged this task as Medium priority.Jun 16 2017, 10:48 AM

Krinkle closed this task as a duplicate of T128012: Support listing modules in extension.json that are registered if another extension is installed.Jul 7 2017, 5:24 AM

Krinkle removed a subtask: T128012: Support listing modules in extension.json that are registered if another extension is installed.

Change 323356 abandoned by Jforrester:
[mediawiki/extensions/Cite@master] Revert "Skip registering RL modules depending on VisualEditor"

Reason:

https://gerrit.wikimedia.org/r/323356