Page MenuHomePhabricator

varnishapi.py AttributeError: VSM_Close
Closed, ResolvedPublic

Description

We've noticed that varnishreqstats occasionally throws the following exception:

Nov 22 23:35:18 cp1055 varnishreqstats[910]: Traceback (most recent call last):
Nov 22 23:35:18 cp1055 varnishreqstats[910]: File "/usr/local/bin/varnishreqstats", line 239, in <module>
Nov 22 23:35:18 cp1055 varnishreqstats[910]: statsd_client=statsd_client
Nov 22 23:35:18 cp1055 varnishreqstats[910]: File "/usr/local/bin/varnishreqstats", line 198, in count_vsl_entries
Nov 22 23:35:18 cp1055 varnishreqstats[910]: varnishlog(vsl_args, count_vsl_entry_callback)
Nov 22 23:35:18 cp1055 varnishreqstats[910]: File "/usr/local/lib/python2.7/dist-packages/varnishlog.py", line 203, in varnishlog
Nov 22 23:35:18 cp1055 varnishreqstats[910]: vlog.execute()
Nov 22 23:35:18 cp1055 varnishreqstats[910]: File "/usr/local/lib/python2.7/dist-packages/varnishlog.py", line 97, in execute
Nov 22 23:35:18 cp1055 varnishreqstats[910]: ret = self.vap.Dispatch(self.vap_callback)
Nov 22 23:35:18 cp1055 varnishreqstats[910]: File "/usr/local/lib/python2.7/dist-packages/varnishapi.py", line 853, in Dispatch
Nov 22 23:35:18 cp1055 varnishreqstats[910]: self.lva.VSM_Close(self.vsm)
Nov 22 23:35:18 cp1055 varnishreqstats[910]: AttributeError: LIBVARNISHAPI instance has no attribute 'VSM_Close'
Nov 22 23:35:18 cp1055 systemd[1]: varnishreqstats-frontend.service: main process exited, code=exited, status=1/FAILURE
Nov 22 23:35:18 cp1055 systemd[1]: Unit varnishreqstats-frontend.service entered failed state.

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript
ema triaged this task as Medium priority.Nov 24 2016, 2:09 PM
ema updated the task description. (Show Details)

Change 323530 had a related patch set uploaded (by Ema):
varnishapi.py: add VSM_Close C binding

https://gerrit.wikimedia.org/r/323530

Change 323530 merged by Ema:
varnishapi.py: add VSM_Close C binding

https://gerrit.wikimedia.org/r/323530

ema claimed this task.