We should add support for skin dependencies on the new skin unit tests.
We should support both extension dependencies in the skin test and skins.
One known skin that requires a extension is BlueSpiceSkin.
| Repo | Needed dependency |
|---|---|
| mediawiki/extensions/CustomPage | mediawiki/skins/CustomPage |
| mediawiki/skins/BlueSpiceSkin | mediawiki/extensions/BlueSpiceFoundation |
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Resolved | hashar | T151593 Add support for skin and extension dependencies in new skin unit test | |||
| Resolved | None | T113860 Fix structure tests for all skins | |||
| Resolved | ashley | T111446 ResourcesTest::testStyleMedia with data set #30 ('skins.bluesky', 'screen', 'skins/BlueSky/resources/css/nonarticle.css', stdClass): Stylesheets should not both specify "media" and contain @media |
Indeed, will have to look into it. We already have support to inject extensions as dependencies but I don't think the job I have created does support it.
@hashar I was looking at it last night but I coulden think of how we can inject skins and extensions. Probably needs a rewrite so it will look up the project mediawiki then do extensions/<ext> or skins/<skin> for the dependacies.
Change 323540 had a related patch set uploaded (by Paladox):
Support extension and skin dependacies in the skin pipeline and extension pipeline
Change 323546 had a related patch set uploaded (by Paladox):
Add a new Skin dependacies test
Change 323546 abandoned by Hashar:
Add a new Skin dependacies test
Reason:
Integrated into https://gerrit.wikimedia.org/r/#/c/323540/
Change 326469 had a related patch set uploaded (by Hashar):
Inject skin/ext dependencies
Mentioned in SAL (#wikimedia-operations) [2016-12-13T09:41:58Z] <hashar> Updating MediaWiki Jenkins jobs to support injecting skin dependencies T151593
Mentioned in SAL (#wikimedia-releng) [2016-12-13T09:42:12Z] <hashar> Updating MediaWiki Jenkins jobs to support injecting skin dependencies T151593
Change 326914 had a related patch set uploaded (by Hashar):
[BlueSpiceSkin] make tests voting
Change 326916 had a related patch set uploaded (by Hashar):
[CustomPage] give reasons for non-voting jobs
mediawiki/skins/BlueSpiceSkin pass and the job is now voting.
mediawiki/extensions/CustomPage still fails, but that is due to a duplicate entry in the registration system which causes MediaWiki to fatal error. Filled that one as T153050.