Exit the template editing mode when the user moves to a different paragraph
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Pginer-WMF
	Nov 25 2016, 12:32 PM

Description

As part of the template translation process (T139332), users can access an isolation mode for translating the template by editing the template parameters.

Currently (as tested in the test server), a template remains in editing mode even when the user moves to edit a different paragraph. When editing a different section, the template editing mode should become closed for the template to reflect the changes and avoid additional complexity in the document (e.g., multiple templates to be expanded at the same time).

Details

	Subject	Repo	Branch	Lines +/-
	Exit the template editing mode when the user moves to a different paragraph	mediawiki/extensions/ContentTranslation	master	+2 -0

Customize query in gerrit

Related Objects
Search...

Status	Assigned	Task
Open	None	T102107 Enable Content Translation in Catalan Wikipedia for all logged-in users
Open	None	T102964 [Epic] Better support for templates in Content Translation
Invalid	None	T139332 CX1 Template editor (tracking) (deprecated)
Open	None	T146760 Fix issues found during user research on template translation prototypes and design reviews
Resolved	Nikerabbit	T151630 Exit the template editing mode when the user moves to a different paragraph

Event Timeline

Pginer-WMF created this task.Nov 25 2016, 12:32 PM

Pginer-WMF edited projects, added Essential-Work; removed OKR-Work.

This is important, because users may lose the data they typed if they don't close the template properly, and this shouldn't be so confusing.

Restricted Application added a project: Language-Engineering October-December 2016. · View Herald TranscriptNov 29 2016, 6:49 PM

In T151630#2832023, @Amire80 wrote:

This is important, because users may lose the data they typed if they don't close the template properly, and this shouldn't be so confusing.

There should be no need to close the template for contents to get saved, but that is a separate story (I created it at T151920). this one is more about helping to focus on the current task at hand, which I agree is important.

Amire80 mentioned this in T150953: Better communicate that changes when editing a template won't be lost on closing.Nov 29 2016, 8:34 PM

Amire80 moved this task from Needs Triage to Oct.-Dec. 2016 on the ContentTranslation board.Dec 5 2016, 8:20 PM

Nikerabbit claimed this task.Dec 14 2016, 6:30 AM

Nikerabbit moved this task from Backlog to In Progress on the Language-Q2-2016-17 Sprint 5 board.

Change 327155 had a related patch set uploaded (by Nikerabbit):
Exit the template editing mode when the user moves to a different paragraph

https://gerrit.wikimedia.org/r/327155

gerritbot added a project: Patch-For-Review.Dec 14 2016, 9:17 AM

Nikerabbit moved this task from In Progress to In Review on the Language-Q2-2016-17 Sprint 5 board.Dec 14 2016, 12:45 PM

+1, it's easy to click "publish" without realising that the X is meant (and required) to save (rather than close/discard) the template. Seen with user: https://it.wikipedia.org/w/index.php?title=The_OA&diff=next&oldid=84782823

Change 327155 merged by jenkins-bot:
Exit the template editing mode when the user moves to a different paragraph

https://gerrit.wikimedia.org/r/327155

ReleaseTaggerBot added a project: MW-1.29-release (WMF-deploy-2017-01-03_(1.29.0-wmf.7)).Dec 20 2016, 7:00 AM

Arrbee moved this task from In Review to QA on the Language-Q2-2016-17 Sprint 5 board.Dec 20 2016, 7:05 AM

Nikerabbit removed a project: Patch-For-Review.Dec 20 2016, 7:05 AM