Page MenuHomePhabricator
Create Task
Maniphest T151651

Category link at the bottom of a page does not get updated in the same session when I add/delete category from Options
Closed, ResolvedPublic1 Estimated Story Points
Actions

Description

Steps to reproduce:

1.Open VE for a page that has some ctaegory links added to it
2.Click on category block in that page

  1. When the Options dialog appears with Category section, make some changes there, like add a category or delete an existing category
  2. Click "Apply Changes"

Observed Result:
The Category block at the end of the page does not reflect the changes done in that session, it does when you save and reopen the page.

Details

SubjectRepoBranchLines +/-
DesktopArticleTarget: Rebuild the category links when they're editedmediawiki/extensions/VisualEditormaster+124 -49
Customize query in gerrit

Related Objects

Event Timeline

Ryasmeen created this task.Nov 25 2016, 8:11 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptNov 25 2016, 8:11 PM
Ryasmeen renamed this task from Category link at the bottom of a page does not get updated in the same session when I added/deleted category from Options to Category link at the bottom of a page does not get updated in the same session when I add/delete category from Options.Nov 25 2016, 8:11 PM
Jdforrester-WMF triaged this task as Medium priority.Nov 29 2016, 8:22 PM
Jdforrester-WMF set the point value for this task to 1.
Jdforrester-WMF moved this task from To Triage to TR1: Releases on the VisualEditor board.
Jdforrester-WMF added a project: VisualEditor-MediaWiki.
gerritbot subscribed.Dec 1 2016, 8:08 PM

Change 324786 had a related patch set uploaded (by DLynch):
DesktopArticleTarget: Rebuild the category links when they're edited

https://gerrit.wikimedia.org/r/324786

gerritbot added a project: Patch-For-Review.Dec 1 2016, 8:08 PM
Jdforrester-WMF closed this task as Resolved.Dec 6 2016, 6:23 PM
Jdforrester-WMF assigned this task to DLynch.
Jdforrester-WMF removed a project: Patch-For-Review.
gerritbot added a comment.Dec 6 2016, 6:31 PM

Change 324786 merged by jenkins-bot:
DesktopArticleTarget: Rebuild the category links when they're edited

https://gerrit.wikimedia.org/r/324786

ReleaseTaggerBot added a project: MW-1.29-release (WMF-deploy-2016-12-13_(1.29.0-wmf.6)).Dec 6 2016, 7:00 PM
Jdforrester-WMF edited projects, added MW-1.29-release (WMF-deploy-2016-12-06_(1.29.0-wmf.5)); removed MW-1.29-release (WMF-deploy-2016-12-13_(1.29.0-wmf.6)).Dec 6 2016, 7:29 PM
Ryasmeen added a comment.EditedDec 6 2016, 11:40 PM

Not sure if this fix has caused this or not, but right now I am seeing it breaking in a different way, If I remove a category it does show that it got removed in that session but when I save and re-open the page I still see that category in both read mode and in VE which didnt use to happen.

Ryasmeen reopened this task as Open.Dec 6 2016, 11:41 PM
Ryasmeen added a comment.Dec 6 2016, 11:52 PM

Created a separate task for the new issue: T152571

DLynch closed this task as Resolved.Dec 7 2016, 12:07 AM
Ryasmeen added a project: Verified.Dec 13 2016, 5:51 PM
matmarex mentioned this in T145268: Always show and update the category display at the end of the page when editing in VE.Jul 17 2020, 2:38 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL