Page MenuHomePhabricator

In Gallery, the order of images in search result section changes randomly while trying to re-edit it
Closed, ResolvedPublic1 Estimated Story Points

Description

Steps to reproduce:

  1. Open VE for a page
  2. Go to Insert>Gallery
  3. After the search results appear for default search term, select one of them and click on "Insert"
  4. Now again open the Gallery dialog to re-edit it.
  5. Click on "Add new image"
  6. First thing to observe is, there is now an extra white column to the right of it which looks very odd

7.Now scroll down a bit

  1. And scroll up to the beginning

Observe that there is a completely different set of images appearing on top of the search results. The order of search results has inconveniently changes.

Sometimes, I cant even find the ones I was considering to add before scrolling down.
If you now just close the gallery and again attempt to edit you will see blank images on top.

This happens both in Beta Cluster and en.wiki.

See the screenshots attached
Initial order with extra space on the right:


New order:

Blank images on third attempt:

In en.wiki :
Extra space on the right:


Blank Images:

Event Timeline

Ryasmeen updated the task description. (Show Details)

Change 324223 had a related patch set uploaded (by Esanders):
Wait until search panel is shown before setting a search query

https://gerrit.wikimedia.org/r/324223

Jdforrester-WMF assigned this task to Esanders.
Jdforrester-WMF triaged this task as Medium priority.
Jdforrester-WMF set the point value for this task to 1.
Jdforrester-WMF moved this task from To Triage to Blocked on the VisualEditor board.

Change 324223 merged by jenkins-bot:
Wait until search panel is shown before setting a search query

https://gerrit.wikimedia.org/r/324223