Maniphest T151795

Update Adyen iframe css to match ingenico
Closed, ResolvedPublic1 Estimated Story Points
Actions

Assigned To

Authored By

	Ejegg
	Nov 28 2016, 7:45 PM

Tags

Referenced Files

	F5062852: Screenshot 2016-12-15 20.47.47.png
	Dec 15 2016, 8:52 PM

	F5062850: Screenshot 2016-12-15 20.47.40.png
	Dec 15 2016, 8:52 PM

Subscribers

Description

The Adyen iframe currently doesn't match the rest of the form when donating on mobile.

Details

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	Adyen iframe form fields should be white on mobile	mediawiki/extensions/DonationInterface	master	+38 -36

Customize query in gerrit

Related Objects

Mentioned Here: T149249: Mobile web form style fixes

Event Timeline

Ejegg created this task.Nov 28 2016, 7:45 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptNov 28 2016, 7:45 PM

• DStrine moved this task from Triage to Sprint +1 on the Fundraising-Backlog board.Nov 28 2016, 9:03 PM

I guess it needs similar styles to T149249. Screenshots for reference.

Adyen:

Screenshot 2016-12-15 20.47.40.png (427×319 px, 31 KB)

Ingenico:

Screenshot 2016-12-15 20.47.47.png (406×328 px, 30 KB)

• DStrine assigned this task to • cwdent.Dec 15 2016, 9:19 PM

• DStrine added projects: Fundraising Sprint Waiting for Godot, Unplanned-Sprint-Work.

Change 327661 had a related patch set uploaded (by Cdentinger):
Adyen iframe form fields should be white on mobile

https://gerrit.wikimedia.org/r/327661

gerritbot added a project: Patch-For-Review.Dec 15 2016, 11:02 PM

• cwdent moved this task from Backlog to Doing on the Fundraising Sprint Waiting for Godot board.Dec 16 2016, 7:41 PM

• cwdent moved this task from Doing to Review on the Fundraising Sprint Waiting for Godot board.Dec 20 2016, 9:07 PM

Change 327661 merged by jenkins-bot:
Adyen iframe form fields should be white on mobile

https://gerrit.wikimedia.org/r/327661

This is deployed and looks better to me, but I'll wait for some more opinions before closing.

ReleaseTaggerBot added a project: MW-1.29-release (WMF-deploy-2017-01-03_(1.29.0-wmf.7)).Dec 21 2016, 5:00 PM

• cwdent closed this task as Resolved.Dec 21 2016, 8:35 PM

• cwdent set the point value for this task to 1.

Looks good to me. Thanks!

• DStrine moved this task from Sprint +1 to Closed Early/Declined/Invalid Tasks on the Fundraising-Backlog board.Jul 6 2017, 4:53 PM