SpellingDictionary: Message 'uls-select-language' required by 'ext.SpellingDictionary.viewByLanguage' must exist
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	hashar
	Nov 29 2016, 1:01 PM

Description

UniversalLanguageSelector has been updated and no more has a 'uls-select-language' message. Hence the tests for SpellingDictionary fail with:

ResourcesTest::testMissingMessages
Message 'uls-select-language' required by 'ext.SpellingDictionary.viewByLanguage' must exist
Failed asserting that false is true.

src/tests/phpunit/structure/ResourcesTest.php:102
src/tests/phpunit/MediaWikiTestCase.php:399
src/maintenance/doMaintenance.php:111

Details

Subject	Repo	Branch	Lines +/-
Drop uls-select-language message	mediawiki/extensions/SpellingDictionary	REL1_31	+0 -1
Drop uls-select-language message	mediawiki/extensions/SpellingDictionary	master	+0 -1
Remove uls-select-language message from being dependant on	mediawiki/extensions/SpellingDictionary	master	+0 -2

Customize query in gerrit

Related Objects
Search...

Status	Assigned	Task
Resolved	hashar	T190097 Migrate all CI jobs from Nodepool, deprecate its use
Resolved	hashar	T183512 [EPIC] Migrate Mediawiki jobs from Nodepool to Docker
Resolved	hashar	T151871 SpellingDictionary: Message 'uls-select-language' required by 'ext.SpellingDictionary.viewByLanguage' must exist

Event Timeline

hashar created this task.Nov 29 2016, 1:01 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptNov 29 2016, 1:01 PM

Message re-use in different context is bad, mkay?

Change 332493 had a related patch set uploaded (by Hashar):
Remove uls-select-language message from being dependant on

https://gerrit.wikimedia.org/r/332493

gerritbot added a project: Patch-For-Review.Jan 17 2017, 9:29 PM

hashar added a subscriber: TTO.Jan 17 2017, 9:32 PM

hashar triaged this task as Low priority.Jun 16 2017, 10:59 AM

Change 332493 abandoned by Paladox:
Remove uls-select-language message from being dependant on

https://gerrit.wikimedia.org/r/332493

Amire80 moved this task from Backlog to Tech debt on the UniversalLanguageSelector board.Oct 31 2017, 11:17 AM

Umherirrender added a parent task: T134090: fix or mark as inactive extensions currently failing CI.Nov 4 2017, 9:15 PM

Umherirrender added a project: Wikimedia-production-error (ARCHIVED -- Shared Build Failure).Apr 13 2018, 7:12 PM

Umherirrender removed a parent task: T134090: fix or mark as inactive extensions currently failing CI.Apr 13 2018, 7:21 PM

Krinkle removed a project: Wikimedia-production-error (ARCHIVED -- Shared Build Failure).Apr 13 2018, 8:23 PM

hashar mentioned this in T183512: [EPIC] Migrate Mediawiki jobs from Nodepool to Docker.Jun 6 2018, 1:03 PM

Change 437749 had a related patch set uploaded (by Hashar; owner: Hashar):
[mediawiki/extensions/SpellingDictionary@master] Drop uls-select-language message

https://gerrit.wikimedia.org/r/437749

hashar added a parent task: T183512: [EPIC] Migrate Mediawiki jobs from Nodepool to Docker.Jun 6 2018, 1:35 PM

hashar closed this task as Resolved.Jun 13 2018, 11:17 AM

hashar claimed this task.

Change 437749 merged by jenkins-bot:
[mediawiki/extensions/SpellingDictionary@master] Drop uls-select-language message

https://gerrit.wikimedia.org/r/437749

Change 653733 had a related patch set uploaded (by Umherirrender; owner: Hashar):
[mediawiki/extensions/SpellingDictionary@REL1_31] Drop uls-select-language message

https://gerrit.wikimedia.org/r/653733

Change 653733 merged by jenkins-bot:
[mediawiki/extensions/SpellingDictionary@REL1_31] Drop uls-select-language message