Page MenuHomePhabricator
Create Task
Maniphest T151878

ApiRevThankIntegrationTest/ApiCoreThankIntegrationTest broken
Closed, ResolvedPublicPRODUCTION ERROR
Actions

Description

14:10:07 ....................PHP Fatal error:  Call to a member function getId() on a non-object in /srv/jenkins-workspace/workspace/mediawiki-extensions-php55/src/extensions/Thanks/tests/phpunit/ApiRevThankIntegrationTest.php on line 32
14:10:07 PHP Stack trace:
14:10:07 PHP   1. {main}() /srv/jenkins-workspace/workspace/mediawiki-extensions-php55/src/tests/phpunit/phpunit.php:0
14:10:07 PHP   2. require() /srv/jenkins-workspace/workspace/mediawiki-extensions-php55/src/tests/phpunit/phpunit.php:163
14:10:07 PHP   3. PHPUnitMaintClass->execute() /srv/jenkins-workspace/workspace/mediawiki-extensions-php55/src/maintenance/doMaintenance.php:111
14:10:07 PHP   4. PHPUnit_TextUI_Command::main() /srv/jenkins-workspace/workspace/mediawiki-extensions-php55/src/tests/phpunit/phpunit.php:133
14:10:07 PHP   5. PHPUnit_TextUI_Command->run() /srv/jenkins-workspace/workspace/mediawiki-extensions-php55/src/vendor/phpunit/phpunit/src/TextUI/Command.php:100
14:10:07 PHP   6. PHPUnit_TextUI_TestRunner->doRun() /srv/jenkins-workspace/workspace/mediawiki-extensions-php55/src/vendor/phpunit/phpunit/src/TextUI/Command.php:149
14:10:07 PHP   7. PHPUnit_Framework_TestSuite->run() /srv/jenkins-workspace/workspace/mediawiki-extensions-php55/src/vendor/phpunit/phpunit/src/TextUI/TestRunner.php:440
14:10:07 PHP   8. PHPUnit_Framework_TestSuite->run() /srv/jenkins-workspace/workspace/mediawiki-extensions-php55/src/vendor/phpunit/phpunit/src/Framework/TestSuite.php:747
14:10:07 PHP   9. PHPUnit_Framework_TestSuite->run() /srv/jenkins-workspace/workspace/mediawiki-extensions-php55/src/vendor/phpunit/phpunit/src/Framework/TestSuite.php:747
14:10:07 PHP  10. PHPUnit_Framework_TestSuite->run() /srv/jenkins-workspace/workspace/mediawiki-extensions-php55/src/vendor/phpunit/phpunit/src/Framework/TestSuite.php:747
14:10:07 PHP  11. MediaWikiTestCase->run() /srv/jenkins-workspace/workspace/mediawiki-extensions-php55/src/vendor/phpunit/phpunit/src/Framework/TestSuite.php:747
14:10:07 PHP  12. PHPUnit_Framework_TestCase->run() /srv/jenkins-workspace/workspace/mediawiki-extensions-php55/src/tests/phpunit/MediaWikiTestCase.php:392
14:10:07 PHP  13. PHPUnit_Framework_TestResult->run() /srv/jenkins-workspace/workspace/mediawiki-extensions-php55/src/vendor/phpunit/phpunit/src/Framework/TestCase.php:724
14:10:07 PHP  14. PHPUnit_Framework_TestCase->runBare() /srv/jenkins-workspace/workspace/mediawiki-extensions-php55/src/vendor/phpunit/phpunit/src/Framework/TestResult.php:612
14:10:07 PHP  15. ApiRevThankIntegrationTest->setUp() /srv/jenkins-workspace/workspace/mediawiki-extensions-php55/src/vendor/phpunit/phpunit/src/Framework/TestCase.php:764
14:10:07 
14:10:07 Fatal error: Call to a member function getId() on a non-object in /srv/jenkins-workspace/workspace/mediawiki-extensions-php55/src/extensions/Thanks/tests/phpunit/ApiRevThankIntegrationTest.php on line 32
14:10:07 
14:10:07 Call Stack:
14:10:07     0.0006     266728   1. {main}() /srv/jenkins-workspace/workspace/mediawiki-extensions-php55/src/tests/phpunit/phpunit.php:0
14:10:07     0.0071     677040   2. require('/srv/jenkins-workspace/workspace/mediawiki-extensions-php55/src/maintenance/doMaintenance.php') /srv/jenkins-workspace/workspace/mediawiki-extensions-php55/src/tests/phpunit/phpunit.php:163
14:10:07     0.3563   24828464   3. PHPUnitMaintClass->execute() /srv/jenkins-workspace/workspace/mediawiki-extensions-php55/src/maintenance/doMaintenance.php:111
14:10:07     0.3725   26487320   4. PHPUnit_TextUI_Command::main() /srv/jenkins-workspace/workspace/mediawiki-extensions-php55/src/tests/phpunit/phpunit.php:133
14:10:07     0.3725   26487944   5. PHPUnit_TextUI_Command->run() /srv/jenkins-workspace/workspace/mediawiki-extensions-php55/src/vendor/phpunit/phpunit/src/TextUI/Command.php:100
14:10:07    45.6700  386506888   6. PHPUnit_TextUI_TestRunner->doRun() /srv/jenkins-workspace/workspace/mediawiki-extensions-php55/src/vendor/phpunit/phpunit/src/TextUI/Command.php:149
14:10:07    46.2357  386868312   7. PHPUnit_Framework_TestSuite->run() /srv/jenkins-workspace/workspace/mediawiki-extensions-php55/src/vendor/phpunit/phpunit/src/TextUI/TestRunner.php:440
14:10:07    47.5294  386964728   8. PHPUnit_Framework_TestSuite->run() /srv/jenkins-workspace/workspace/mediawiki-extensions-php55/src/vendor/phpunit/phpunit/src/Framework/TestSuite.php:747
14:10:07    82.7958  431388720   9. PHPUnit_Framework_TestSuite->run() /srv/jenkins-workspace/workspace/mediawiki-extensions-php55/src/vendor/phpunit/phpunit/src/Framework/TestSuite.php:747
14:10:07    95.1473  498006496  10. PHPUnit_Framework_TestSuite->run() /srv/jenkins-workspace/workspace/mediawiki-extensions-php55/src/vendor/phpunit/phpunit/src/Framework/TestSuite.php:747
14:10:07    96.6548  500843752  11. MediaWikiTestCase->run() /srv/jenkins-workspace/workspace/mediawiki-extensions-php55/src/vendor/phpunit/phpunit/src/Framework/TestSuite.php:747
14:10:07    96.6558  500831616  12. PHPUnit_Framework_TestCase->run() /srv/jenkins-workspace/workspace/mediawiki-extensions-php55/src/tests/phpunit/MediaWikiTestCase.php:392
14:10:07    96.6559  500831616  13. PHPUnit_Framework_TestResult->run() /srv/jenkins-workspace/workspace/mediawiki-extensions-php55/src/vendor/phpunit/phpunit/src/Framework/TestCase.php:724
14:10:07    96.6561  500832824  14. PHPUnit_Framework_TestCase->runBare() /srv/jenkins-workspace/workspace/mediawiki-extensions-php55/src/vendor/phpunit/phpunit/src/Framework/TestResult.php:612
14:10:07    96.6562  500849736  15. ApiRevThankIntegrationTest->setUp() /srv/jenkins-workspace/workspace/mediawiki-extensions-php55/src/vendor/phpunit/phpunit/src/Framework/TestCase.php:764

Details

SubjectRepoBranchLines +/-
ApiCoreThankIntegrationTest: Fix intermittent failuresmediawiki/extensions/Thanksmaster+10 -1
Customize query in gerrit

Related Objects

Event Timeline

Reedy created this task.Nov 29 2016, 2:14 PM
Restricted Application added a project: Collaboration-Team-Triage. · View Herald TranscriptNov 29 2016, 2:14 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Reedy added a comment.Nov 29 2016, 2:33 PM

Looks intermittant...

• jmatazzoni assigned this task to Catrope.Nov 30 2016, 1:45 AM
• jmatazzoni edited projects, added Collaboration-Team-Triage (Collab-Team-Q2-Oct-Dec-2016); removed Collaboration-Team-Triage.
• jmatazzoni moved this task from Untriaged to In Development on the Collaboration-Team-Triage (Collab-Team-Q2-Oct-Dec-2016) board.
Catrope merged a task: T153755: Jenkins ends with a Thanks related error.Dec 20 2016, 2:58 PM
Catrope merged a task: T153755: Jenkins ends with a Thanks related error.
Catrope added a subscriber: Huji.
• jmatazzoni edited projects, added Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017); removed Collaboration-Team-Triage (Collab-Team-Q2-Oct-Dec-2016).Jan 5 2017, 10:29 PM
• jmatazzoni moved this task from Untriaged to In Development on the Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017) board.Jan 5 2017, 10:33 PM
Jdforrester-WMF removed Catrope as the assignee of this task.Mar 28 2017, 4:24 PM
Jdforrester-WMF added a subscriber: Catrope.
• jmatazzoni edited projects, added Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017); removed Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017).Apr 18 2017, 1:06 AM
• jmatazzoni moved this task from Untriaged to In Development on the Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017) board.
• jmatazzoni edited projects, added Collaboration-Team-Triage (Collab-Team-This-Quarter); removed Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017).Jul 14 2017, 12:14 AM
• jmatazzoni moved this task from Untriaged to In Development on the Collaboration-Team-Triage (Collab-Team-This-Quarter) board.Jul 14 2017, 12:17 AM
Legoktm added a subscriber: Legoktm.Jul 23 2017, 11:24 PM

This is still flaky: https://integration.wikimedia.org/ci/job/mediawiki-extensions-hhvm-jessie/18722/console

Reedy added a comment.Sep 5 2017, 10:54 PM

And still

22:23:08 ............................PHP Fatal error:  Call to a member function getId() on a non-object in /home/jenkins/workspace/mediawiki-extensions-php55-trusty/src/extensions/Thanks/tests/phpunit/ApiRevThankIntegrationTest.php on line 32
22:23:08 PHP Stack trace:
22:23:08 PHP   1. {main}() /home/jenkins/workspace/mediawiki-extensions-php55-trusty/src/tests/phpunit/phpunit.php:0
22:23:08 PHP   2. require() /home/jenkins/workspace/mediawiki-extensions-php55-trusty/src/tests/phpunit/phpunit.php:163
22:23:08 PHP   3. PHPUnitMaintClass->execute() /home/jenkins/workspace/mediawiki-extensions-php55-trusty/src/maintenance/doMaintenance.php:92
22:23:08 PHP   4. PHPUnit_TextUI_Command::main() /home/jenkins/workspace/mediawiki-extensions-php55-trusty/src/tests/phpunit/phpunit.php:133
22:23:08 PHP   5. PHPUnit_TextUI_Command->run() /home/jenkins/workspace/mediawiki-extensions-php55-trusty/src/vendor/phpunit/phpunit/src/TextUI/Command.php:100
22:23:08 PHP   6. PHPUnit_TextUI_TestRunner->doRun() /home/jenkins/workspace/mediawiki-extensions-php55-trusty/src/vendor/phpunit/phpunit/src/TextUI/Command.php:149
22:23:08 PHP   7. PHPUnit_Framework_TestSuite->run() /home/jenkins/workspace/mediawiki-extensions-php55-trusty/src/vendor/phpunit/phpunit/src/TextUI/TestRunner.php:440
22:23:08 PHP   8. PHPUnit_Framework_TestSuite->run() /home/jenkins/workspace/mediawiki-extensions-php55-trusty/src/vendor/phpunit/phpunit/src/Framework/TestSuite.php:722
22:23:08 PHP   9. PHPUnit_Framework_TestSuite->run() /home/jenkins/workspace/mediawiki-extensions-php55-trusty/src/vendor/phpunit/phpunit/src/Framework/TestSuite.php:722
22:23:08 PHP  10. PHPUnit_Framework_TestSuite->run() /home/jenkins/workspace/mediawiki-extensions-php55-trusty/src/vendor/phpunit/phpunit/src/Framework/TestSuite.php:722
22:23:08 PHP  11. MediaWikiTestCase->run() /home/jenkins/workspace/mediawiki-extensions-php55-trusty/src/vendor/phpunit/phpunit/src/Framework/TestSuite.php:722
22:23:08 PHP  12. PHPUnit_Framework_TestCase->run() /home/jenkins/workspace/mediawiki-extensions-php55-trusty/src/tests/phpunit/MediaWikiTestCase.php:415
22:23:08 PHP  13. PHPUnit_Framework_TestResult->run() /home/jenkins/workspace/mediawiki-extensions-php55-trusty/src/vendor/phpunit/phpunit/src/Framework/TestCase.php:724
22:23:08 PHP  14. PHPUnit_Framework_TestCase->runBare() /home/jenkins/workspace/mediawiki-extensions-php55-trusty/src/vendor/phpunit/phpunit/src/Framework/TestResult.php:612
22:23:08 PHP  15. ApiRevThankIntegrationTest->setUp() /home/jenkins/workspace/mediawiki-extensions-php55-trusty/src/vendor/phpunit/phpunit/src/Framework/TestCase.php:764
22:23:08 
22:23:08 Fatal error: Call to a member function getId() on a non-object in /home/jenkins/workspace/mediawiki-extensions-php55-trusty/src/extensions/Thanks/tests/phpunit/ApiRevThankIntegrationTest.php on line 32
22:23:08 
22:23:08 Call Stack:
22:23:08     0.0004     268328   1. {main}() /home/jenkins/workspace/mediawiki-extensions-php55-trusty/src/tests/phpunit/phpunit.php:0
22:23:08     0.0046     684024   2. require('/home/jenkins/workspace/mediawiki-extensions-php55-trusty/src/maintenance/doMaintenance.php') /home/jenkins/workspace/mediawiki-extensions-php55-trusty/src/tests/phpunit/phpunit.php:163
22:23:08     0.2141   27660384   3. PHPUnitMaintClass->execute() /home/jenkins/workspace/mediawiki-extensions-php55-trusty/src/maintenance/doMaintenance.php:92
22:23:08     0.2256   29249256   4. PHPUnit_TextUI_Command::main() /home/jenkins/workspace/mediawiki-extensions-php55-trusty/src/tests/phpunit/phpunit.php:133
22:23:08     0.2256   29249880   5. PHPUnit_TextUI_Command->run() /home/jenkins/workspace/mediawiki-extensions-php55-trusty/src/vendor/phpunit/phpunit/src/TextUI/Command.php:100
22:23:08    19.9740  474448208   6. PHPUnit_TextUI_TestRunner->doRun() /home/jenkins/workspace/mediawiki-extensions-php55-trusty/src/vendor/phpunit/phpunit/src/TextUI/Command.php:149
22:23:08    20.2411  474810392   7. PHPUnit_Framework_TestSuite->run() /home/jenkins/workspace/mediawiki-extensions-php55-trusty/src/vendor/phpunit/phpunit/src/TextUI/TestRunner.php:440
22:23:08    20.8219  474918568   8. PHPUnit_Framework_TestSuite->run() /home/jenkins/workspace/mediawiki-extensions-php55-trusty/src/vendor/phpunit/phpunit/src/Framework/TestSuite.php:722
22:23:08    37.7013  521451224   9. PHPUnit_Framework_TestSuite->run() /home/jenkins/workspace/mediawiki-extensions-php55-trusty/src/vendor/phpunit/phpunit/src/Framework/TestSuite.php:722
22:23:08   104.0814  765396320  10. PHPUnit_Framework_TestSuite->run() /home/jenkins/workspace/mediawiki-extensions-php55-trusty/src/vendor/phpunit/phpunit/src/Framework/TestSuite.php:722
22:23:08   104.3893  766701560  11. MediaWikiTestCase->run() /home/jenkins/workspace/mediawiki-extensions-php55-trusty/src/vendor/phpunit/phpunit/src/Framework/TestSuite.php:722
22:23:08   104.3895  766691800  12. PHPUnit_Framework_TestCase->run() /home/jenkins/workspace/mediawiki-extensions-php55-trusty/src/tests/phpunit/MediaWikiTestCase.php:415
22:23:08   104.3896  766691800  13. PHPUnit_Framework_TestResult->run() /home/jenkins/workspace/mediawiki-extensions-php55-trusty/src/vendor/phpunit/phpunit/src/Framework/TestCase.php:724
22:23:08   104.3897  766693008  14. PHPUnit_Framework_TestCase->runBare() /home/jenkins/workspace/mediawiki-extensions-php55-trusty/src/vendor/phpunit/phpunit/src/Framework/TestResult.php:612
22:23:08   104.3898  766709920  15. ApiRevThankIntegrationTest->setUp() /home/jenkins/workspace/mediawiki-extensions-php55-trusty/src/vendor/phpunit/phpunit/src/Framework/TestCase.php:764
Jdforrester-WMF added a subscriber: Jdforrester-WMF.Sep 6 2017, 12:24 AM
Nikerabbit added a subscriber: Nikerabbit.Oct 10 2017, 12:40 PM

Also happened in https://gerrit.wikimedia.org/r/#/c/382436/2

matmarex added a subscriber: matmarex.Nov 2 2017, 11:08 PM

Again: https://gerrit.wikimedia.org/r/#/c/387439/1

matmarex removed a subscriber: matmarex.Nov 2 2017, 11:08 PM
Daimona added a subscriber: Daimona.Feb 9 2018, 12:24 PM

This happened again with https://gerrit.wikimedia.org/r/#/c/409312/. A simple recheck solved the problem.

matmarex added a comment.Feb 20 2018, 9:03 PM

Again: https://gerrit.wikimedia.org/r/#/c/408326/

matmarex mentioned this in T189752: ThanksHooks::insertThankLink: Call to a member function getUser() on a non-object (null).Mar 14 2018, 10:38 PM
matmarex renamed this task from ApiRevThankIntegrationTest broken to ApiRevThankIntegrationTest/ApiCoreThankIntegrationTest broken.Mar 14 2018, 11:21 PM

Again: https://gerrit.wikimedia.org/r/#/c/419501/

matmarex moved this task from In Development to Untriaged on the Collaboration-Team-Triage (Collab-Team-This-Quarter) board.Mar 14 2018, 11:24 PM

Could I ask you to triage this again? These failures occur quite regularly and make developers sad every time :( [I don't think this is "In Development".]

Krinkle added a subscriber: Krinkle.EditedMar 19 2018, 3:46 AM

(Again: https://gerrit.wikimedia.org/r/#/c/420215/)

PHP Fatal error:  Call to a member function getId() on a non-object in /home/jenkins/workspace/mediawiki-extensions-php55-jessie/src/extensions/Thanks/tests/phpunit/ApiCoreThankIntegrationTest.php on line 37

Please disable the flaky test if no time is available to investigate the fix. The faulty test is not adding value in its current form. Otherwise, we should remove Thanks from the shared CI pipeline. The job will still run on commits to Thanks.git, but currently Thanks' broken tests also affect changes for MediaWiki core and other extensions.

gerritbot added a subscriber: gerritbot.Mar 20 2018, 1:04 AM

Change 420622 had a related patch set uploaded (by Catrope; owner: Catrope):
[mediawiki/extensions/Thanks@master] ApiCoreThankIntegrationTest: Fix intermittent failures

https://gerrit.wikimedia.org/r/420622

gerritbot added a project: Patch-For-Review.Mar 20 2018, 1:04 AM
Krinkle closed this task as Resolved.Mar 20 2018, 2:06 AM
Krinkle claimed this task.
Krinkle mentioned this in T170003: Flow\Tests\Model\UUIDTest::invalidInputProvider() can randomly fail.
gerritbot added a comment.Mar 20 2018, 2:23 AM

Change 420622 merged by jenkins-bot:
[mediawiki/extensions/Thanks@master] ApiCoreThankIntegrationTest: Fix intermittent failures

https://gerrit.wikimedia.org/r/420622

Krinkle edited projects, added Wikimedia-production-error (ARCHIVED -- Shared Build Failure); removed Patch-For-Review.Mar 20 2018, 2:40 AM
ReleaseTaggerBot added a project: MW-1.31-release-notes (WMF-deploy-2018-03-20 (1.31.0-wmf.26)).Mar 20 2018, 3:00 AM
matmarex awarded a token.Mar 20 2018, 7:53 AM
mmodell changed the subtype of this task from "Task" to "Production Error".Aug 28 2019, 11:10 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL