Page MenuHomePhabricator
Create Task
Maniphest T151956

Use isDisabled() instead of isBlank() in getGrantName()
Closed, ResolvedPublic
Actions

Description

Currently, getGrantName in User.php uses isBlank() to determine whether to display a message. However, this does not check if a message is disabled. Although these messages may not be disabled often, it is a better check to use isDisabled().

Details

Related Changes in Gerrit:
SubjectAuthorRepoBranchLines +/-
Use isDisabled() instead of isBlank() in getGrantName in User.phpMtDumediawiki/coremaster+2 -1
Customize query in gerrit

Event Timeline

MtDu created this task.Nov 29 2016, 10:29 PM
gerritbot subscribed.Nov 29 2016, 10:37 PM

Change 324337 had a related patch set uploaded (by MtDu):
Use isDisabled() instead of isBlank() in getGrantName in User.php

https://gerrit.wikimedia.org/r/324337

gerritbot added a project: Patch-For-Review.Nov 29 2016, 10:37 PM
Florian closed this task as Resolved.Nov 29 2016, 10:51 PM
Florian added a project: MediaWiki-General.
gerritbot added a comment.Nov 29 2016, 11:03 PM

Change 324337 merged by jenkins-bot:
Use isDisabled() instead of isBlank() in getGrantName in User.php

https://gerrit.wikimedia.org/r/324337

ReleaseTaggerBot added projects: MW-1.29-release-notes, MW-1.29-release (WMF-deploy-2016-12-06_(1.29.0-wmf.5)).Nov 30 2016, 12:01 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits