Page MenuHomePhabricator
Create Task
Maniphest T151961

SpecialUserrights: fetchUser() called with wrong parameters
Closed, ResolvedPublicPRODUCTION ERROR
Actions

Description

Spotted in production as of 1.29.0-wmf.4:

Warning: fetchUser() expects exactly 2 parameters, 1 given in /srv/mediawiki/php-1.29.0-wmf.4/includes/specials/SpecialUserrights.php on line 335

Details

SubjectRepoBranchLines +/-
SpecialUserrights: Make new fetchUser() parameter optionalmediawiki/coremaster+1 -1
SpecialUserrights: Make new fetchUser() parameter optionalmediawiki/corewmf/1.29.0-wmf.4+1 -1
Customize query in gerrit

Event Timeline

• demon created this task.Nov 29 2016, 11:16 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptNov 29 2016, 11:16 PM
• demon added a comment.Nov 29 2016, 11:21 PM

Looks like the bad callers are ApiUserrights and ApiQueryUsers. The former should probably pass true as its $write parameter, the latter looks like it should pass false.

Krenair added subscribers: Florian, Huji, Jackmcbarn, Krenair.Nov 30 2016, 5:02 PM

https://gerrit.wikimedia.org/r/#/c/107009/9

matmarex claimed this task.Nov 30 2016, 5:56 PM
matmarex subscribed.

Whoops.

matmarex added a comment.Nov 30 2016, 6:03 PM

For ApiQueryUsers it doesn't really matter, it looks like the code path which checks this can't be reached (as it can't pass cross-wiki user names).

gerritbot subscribed.Nov 30 2016, 6:05 PM

Change 324511 had a related patch set uploaded (by Bartosz Dziewoński):
SpecialUserrights: Make new fetchUser() parameter optional

https://gerrit.wikimedia.org/r/324511

gerritbot added a project: Patch-For-Review.Nov 30 2016, 6:05 PM
matmarex removed a project: MediaWiki-Core-AuthManager.Nov 30 2016, 6:05 PM
gerritbot added a comment.Nov 30 2016, 6:14 PM

Change 324516 had a related patch set uploaded (by Chad):
SpecialUserrights: Make new fetchUser() parameter optional

https://gerrit.wikimedia.org/r/324516

gerritbot added a comment.Nov 30 2016, 6:27 PM

Change 324511 merged by jenkins-bot:
SpecialUserrights: Make new fetchUser() parameter optional

https://gerrit.wikimedia.org/r/324511

gerritbot added a comment.Nov 30 2016, 6:43 PM

Change 324516 merged by jenkins-bot:
SpecialUserrights: Make new fetchUser() parameter optional

https://gerrit.wikimedia.org/r/324516

ReleaseTaggerBot added projects: MW-1.29-release-notes, MW-1.29-release (WMF-deploy-2016-11-29_(1.29.0-wmf.4)), MW-1.29-release (WMF-deploy-2016-12-06_(1.29.0-wmf.5)).Nov 30 2016, 7:00 PM
• demon closed this task as Resolved.Nov 30 2016, 8:10 PM
• mmodell changed the subtype of this task from "Task" to "Production Error".Aug 28 2019, 11:11 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL