Page MenuHomePhabricator
Create Task
Maniphest T151992

Editing a gallery without "File:" prefixes throws JS error in VE
Closed, ResolvedPublic1 Estimated Story Points
Actions

Description

Steps to reproduce:

  1. Go to https://de.wikipedia.org/wiki/Hilfe:Galerie?veaction=edit
  2. Scroll down to first gallery, try to edit it.

Expected: You can edit the gallery.

Actual: The page is grayed out, JS console shows an error: "TypeError: item is undefined".

Related Objects

Event Timeline

Schnark created this task.Nov 30 2016, 10:58 AM
Restricted Application added a project: VisualEditor. · View Herald TranscriptNov 30 2016, 10:58 AM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Jdforrester-WMF closed this task as Resolved.EditedNov 30 2016, 4:24 PM
Jdforrester-WMF assigned this task to Esanders.
Jdforrester-WMF triaged this task as High priority.
Jdforrester-WMF added a project: MW-1.29-release (WMF-deploy-2016-12-06_(1.29.0-wmf.5)).
Jdforrester-WMF moved this task from To Triage to TR0: Interrupt on the VisualEditor board.
Jdforrester-WMF set the point value for this task to 1.
Jdforrester-WMF subscribed.

Ouch. Happily, we just fixed this as part of other fixes for galleries (code: https://gerrit.wikimedia.org/r/#/c/323090/). It will roll out to production next week (tested against master). Sorry for the disruption!

Jdforrester-WMF reassigned this task from Esanders to Tchanders.Nov 30 2016, 4:25 PM
Jdforrester-WMF added a subscriber: Esanders.
Jdforrester-WMF edited projects, added MW-1.29-release (WMF-deploy-2016-11-29_(1.29.0-wmf.4)); removed MW-1.29-release (WMF-deploy-2016-12-06_(1.29.0-wmf.5)).Nov 30 2016, 5:30 PM

Sorry, wrong patch previously; it'll roll out tomorrow.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL