Page MenuHomePhabricator

Temporary section collapsing code is leaking to other skins
Closed, ResolvedPublic

Description

Visit https://en.wikipedia.org/wiki/Book in a desktop browser and inspect the source code. You'll notice that the following JS code is there.

function mfTempOpenSection(id){var block=document.getElementById("mf-section-"+id);block.className+=" open-block";block.previousSibling.className+=" open-block";}

The code should only be there if the skin is minerva.

Details

Related Gerrit Patches:
mediawiki/extensions/MobileFrontend : masterFix: leak of mfTempOpenSection() Minerva-only JavaScript function

Event Timeline

Restricted Application added a subscriber: Aklapper. ยท View Herald TranscriptNov 30 2016, 3:53 PM
bmansurov triaged this task as Low priority.Nov 30 2016, 5:12 PM
bmansurov moved this task from Incoming to Triaged but Future on the Readers-Web-Backlog board.
TheDJ added a subscriber: TheDJ.Dec 29 2016, 12:50 PM

I noticed this too today.

Change 333834 had a related patch set uploaded (by Niedzielski):
Fix: leak of mfTempOpenSection() Minerva-only JavaScript function

https://gerrit.wikimedia.org/r/333834

Niedzielski added a subscriber: Niedzielski.

o/ I don't really know what I'm doing yet but I took a stab at this ticket. Please excuse n00b mistakes :]

Change 333834 merged by jenkins-bot:
Fix: leak of mfTempOpenSection() Minerva-only JavaScript function

https://gerrit.wikimedia.org/r/333834