Page MenuHomePhabricator

Temporary section collapsing code is leaking to other skins
Closed, ResolvedPublic

Description

Visit https://en.wikipedia.org/wiki/Book in a desktop browser and inspect the source code. You'll notice that the following JS code is there.

function mfTempOpenSection(id){var block=document.getElementById("mf-section-"+id);block.className+=" open-block";block.previousSibling.className+=" open-block";}

The code should only be there if the skin is minerva.

Event Timeline

Change 333834 had a related patch set uploaded (by Niedzielski):
Fix: leak of mfTempOpenSection() Minerva-only JavaScript function

https://gerrit.wikimedia.org/r/333834

Niedzielski subscribed.

o/ I don't really know what I'm doing yet but I took a stab at this ticket. Please excuse n00b mistakes :]

Change 333834 merged by jenkins-bot:
Fix: leak of mfTempOpenSection() Minerva-only JavaScript function

https://gerrit.wikimedia.org/r/333834