Maniphest T152022

Fail mail on 'city is too long'
Closed, ResolvedPublic1 Estimated Story Points
Actions

Description

I checked a few of these and it was people using the city field for complicated address-like stuff. We should be able to handle that gracefully.

Details

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	Add 'maxlength' attributes to personal info fields	mediawiki/extensions/DonationInterface	master	+5 -5
	Do not hard-fail on overlong city.	wikimedia/fundraising/crm	master	+25 -9

Customize query in gerrit

Event Timeline

• cwdent created this task.Nov 30 2016, 6:10 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptNov 30 2016, 6:10 PM

Yep, at least truncate before sending to the queue. Guess add maxlength to the input fields too.

Change 324550 had a related patch set uploaded (by Ejegg):
Add 'maxlength' attributes to personal info fields

https://gerrit.wikimedia.org/r/324550

gerritbot added a project: Patch-For-Review.Nov 30 2016, 8:32 PM

Change 324555 had a related patch set uploaded (by Eileen):
Do not hard-fail on overlong city.

https://gerrit.wikimedia.org/r/324555

• DStrine added projects: Fundraising Sprint Waiting for Godot, Unplanned-Sprint-Work.Nov 30 2016, 9:03 PM

• DStrine moved this task from Triage to Completed in Q2 1617 on the Fundraising-Backlog board.

Eileenmcnaughton moved this task from Backlog to Review on the Fundraising Sprint Waiting for Godot board.Nov 30 2016, 9:18 PM

Change 324555 merged by jenkins-bot:
Do not hard-fail on overlong city.

https://gerrit.wikimedia.org/r/324555

Eileenmcnaughton moved this task from Review to Pending Deployment on the Fundraising Sprint Waiting for Godot board.Dec 1 2016, 6:38 AM

Eileenmcnaughton moved this task from Pending Deployment to Done on the Fundraising Sprint Waiting for Godot board.Dec 4 2016, 8:22 PM

@Ejegg should we return this to review since there is still your mustache patch against it?

Ejegg moved this task from Done to Review on the Fundraising Sprint Waiting for Godot board.Dec 13 2016, 10:49 PM

awight assigned this task to Eileenmcnaughton.Dec 14 2016, 9:02 PM

Change 324550 merged by jenkins-bot:
Add 'maxlength' attributes to personal info fields

https://gerrit.wikimedia.org/r/324550

ReleaseTaggerBot added a project: MW-1.29-release (WMF-deploy-2017-01-03_(1.29.0-wmf.7)).Dec 21 2016, 10:00 PM

Ejegg moved this task from Review to Done on the Fundraising Sprint Waiting for Godot board.Dec 21 2016, 11:43 PM

Ejegg moved this task from Done to Pending Deployment on the Fundraising Sprint Waiting for Godot board.

Ejegg moved this task from Pending Deployment to Done on the Fundraising Sprint Waiting for Godot board.Jan 3 2017, 10:20 PM

Eileenmcnaughton closed this task as Resolved.Jan 3 2017, 10:22 PM