Page MenuHomePhabricator
Create Task
Maniphest T152053

GalleryDialog: Items should scroll into view when selected
Closed, ResolvedPublic1 Estimated Story Points
Actions

Description

This is particularly important for when a new image is added to the bottom of a long list, as the list may still be at the top.

OO.ui.Element's have a scrollElementIntoView method that should work.

Details

Related Changes in Gerrit:
SubjectAuthorRepoBranchLines +/-
Scroll highlighted item into view in gallery dialogTchandersmediawiki/extensions/VisualEditormaster+3 -0
Customize query in gerrit

Event Timeline

Esanders created this task.Nov 30 2016, 10:40 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptNov 30 2016, 10:40 PM
Jdforrester-WMF triaged this task as Medium priority.Nov 30 2016, 11:15 PM
Jdforrester-WMF edited projects, added: MediaWiki-Gallery, VisualEditor-MediaWiki-Media; removed: VisualEditor-MediaWiki.
Jdforrester-WMF moved this task from To Triage to Blocked on the VisualEditor board.
Jdforrester-WMF set the point value for this task to 1.
gerritbot subscribed.Dec 3 2016, 3:47 PM

Change 325103 had a related patch set uploaded (by Tchanders):
Scroll highlighted item into view in gallery dialog

https://gerrit.wikimedia.org/r/325103

gerritbot added a project: Patch-For-Review.Dec 3 2016, 3:47 PM
Jdforrester-WMF closed this task as Resolved.Dec 6 2016, 6:22 PM
Jdforrester-WMF removed a project: Patch-For-Review.
gerritbot added a comment.Dec 6 2016, 6:30 PM

Change 325103 merged by jenkins-bot:
Scroll highlighted item into view in gallery dialog

https://gerrit.wikimedia.org/r/325103

ReleaseTaggerBot added a project: MW-1.29-release (WMF-deploy-2016-12-13_(1.29.0-wmf.6)).Dec 6 2016, 7:00 PM
Jdforrester-WMF edited projects, added: MW-1.29-release (WMF-deploy-2016-12-06_(1.29.0-wmf.5)); removed: MW-1.29-release (WMF-deploy-2016-12-13_(1.29.0-wmf.6)).Dec 6 2016, 7:28 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits