Page MenuHomePhabricator
Create Task
Maniphest T152079

Fix stylelint errors
Closed, ResolvedPublic
Actions

Description

We have stylint rules defined in CX code, but at this point, not all tests pass. So I did not make it part of CI tests.

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Stylelint error fixesmediawiki/extensions/ContentTranslationmaster+9 -9
Stylelint: Fix Unexpected value "none" for property "border"mediawiki/extensions/ContentTranslationmaster+11 -11
Update list of supported browsersmediawiki/extensions/ContentTranslationmaster+2 -2
Fix stylelint errors: Part 1mediawiki/extensions/ContentTranslationmaster+614 -592
Customize query in gerrit

Related Objects
Search...

StatusSubtypeAssignedTask
 ResolvedKartikMistryT155669 Integrate stylelint test to CI
 ResolvedKartikMistryT152079 Fix stylelint errors

Event Timeline

santhosh created this task.Dec 1 2016, 8:15 AM
Restricted Application added a project: Language-Engineering October-December 2016. · View Herald TranscriptDec 1 2016, 8:15 AM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Amire80 moved this task from Needs Triage to Oct.-Dec. 2016 on the ContentTranslation board.Dec 5 2016, 8:16 PM
• Arrbee triaged this task as Medium priority.Dec 7 2016, 6:47 AM
• Arrbee moved this task from Backlog to In Progress on the Language-Q2-2016-17 Sprint 5 board.Dec 12 2016, 7:02 AM
gerritbot subscribed.Dec 12 2016, 7:53 AM

Change 326391 had a related patch set uploaded (by KartikMistry):
WIP: Fix stylelint errors

https://gerrit.wikimedia.org/r/326391

gerritbot added a project: Patch-For-Review.Dec 12 2016, 7:53 AM
gerritbot added a comment.Dec 12 2016, 7:58 AM

Change 326392 had a related patch set uploaded (by KartikMistry):
Enable stylelint test

https://gerrit.wikimedia.org/r/326392

KartikMistry claimed this task.Dec 13 2016, 7:10 AM
KartikMistry moved this task from In Progress to In Review on the Language-Q2-2016-17 Sprint 5 board.Dec 20 2016, 7:04 AM
gerritbot added a comment.Dec 20 2016, 12:09 PM

Change 326391 merged by KartikMistry:
Fix stylelint errors: Part 1

https://gerrit.wikimedia.org/r/326391

gerritbot added a comment.Dec 21 2016, 1:53 PM

Change 328515 had a related patch set uploaded (by KartikMistry):
Update list of supported browsers

https://gerrit.wikimedia.org/r/328515

gerritbot added a comment.Dec 22 2016, 5:00 AM

Change 328515 merged by jenkins-bot:
Update list of supported browsers

https://gerrit.wikimedia.org/r/328515

gerritbot added a comment.Dec 22 2016, 5:14 AM

Change 328624 had a related patch set uploaded (by KartikMistry):
Stylelint: Fix Unexpected value "none" for property "border"

https://gerrit.wikimedia.org/r/328624

ReleaseTaggerBot added a project: MW-1.29-release (WMF-deploy-2017-01-03_(1.29.0-wmf.7)).Dec 22 2016, 6:00 AM
KartikMistry renamed this task from Fix all stylelint errors and integrate stylelint test to CI to [Tracker] Fix all stylelint errors and integrate stylelint test to CI.Dec 22 2016, 6:38 AM
KartikMistry renamed this task from [Tracker] Fix all stylelint errors and integrate stylelint test to CI to Fix all stylelint errors and integrate stylelint test to CI.Dec 23 2016, 7:07 AM
gerritbot added a comment.Dec 23 2016, 8:54 AM

Change 328624 merged by jenkins-bot:
Stylelint: Fix Unexpected value "none" for property "border"

https://gerrit.wikimedia.org/r/328624

gerritbot added a comment.Jan 4 2017, 7:58 AM

Change 330377 had a related patch set uploaded (by KartikMistry):
Stylelint error fixes

https://gerrit.wikimedia.org/r/330377

• Arrbee subscribed.Jan 18 2017, 7:17 PM

Timeboxed for 27th January 2017

• Arrbee edited projects, added Language-2017 Sprint 1; removed Language-Q2-2016-17 Sprint 5.Jan 18 2017, 7:17 PM
• Arrbee moved this task from Backlog to QA on the Language-2017 Sprint 1 board.Jan 18 2017, 7:27 PM
gerritbot added a comment.Jan 18 2017, 7:30 PM

Change 330377 merged by jenkins-bot:
Stylelint error fixes

https://gerrit.wikimedia.org/r/330377

ReleaseTaggerBot added a project: MW-1.29-release (WMF-deploy-2017-01-24_(1.29.0-wmf.9)).Jan 18 2017, 8:00 PM
KartikMistry renamed this task from Fix all stylelint errors and integrate stylelint test to CI to Fix stylelint errors.Jan 18 2017, 9:18 PM
KartikMistry updated the task description. (Show Details)
KartikMistry moved this task from QA to Done on the Language-2017 Sprint 1 board.Jan 19 2017, 7:17 PM
• Arrbee closed this task as Resolved.Feb 7 2017, 7:06 AM
Restricted Application added a project: Language-team January-March 2017. · View Herald TranscriptFeb 7 2017, 7:06 AM
KartikMistry added a parent task: T155669: Integrate stylelint test to CI.Feb 7 2017, 7:22 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits