Page MenuHomePhabricator
Create Task
Maniphest T152155

Thumbnails are not showing in search on multiple platforms
Closed, ResolvedPublic
Actions

Assigned To
EBernhardson
Authored By
• Deskana
Dec 1 2016, 10:59 PM
Tags
Referenced Files
F4933195: Screen Shot 2016-12-01 at 4.06.12 PM.png
Dec 1 2016, 11:07 PM
F4933143: Screen Shot 2016-12-01 at 14.58.27.png
Dec 1 2016, 10:59 PM
Subscribers
Aklapper
• bmansurov
• debt
• Deskana
EBernhardson
gerritbot
greg
View All 16 Subscribers

Description

wikipedia.org:

Screen Shot 2016-12-01 at 14.58.27.png (1×968 px, 133 KB)

Also verified on latest production releases of iOS and Android apps.

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Add job queue option for initImageData maintenance scriptmediawiki/extensions/PageImageswmf/1.29.0-wmf.5+77 -8
Add job queue option for initImageData maintenance scriptmediawiki/extensions/PageImageswmf/1.29.0-wmf.4+79 -10
Add job queue option for initImageData maintenance scriptmediawiki/extensions/PageImageswmf/1.29.0-wmf.4+79 -10
Add job queue option for initImageData maintenance scriptmediawiki/extensions/PageImagesmaster+77 -8
Add job queue option for initImageData maintenance scriptmediawiki/extensions/PageImagesmaster+79 -10
Page images return non-free images by defaultmediawiki/extensions/PageImageswmf/1.29.0-wmf.4+2 -2
Page images return non-free images by defaultmediawiki/extensions/PageImagesmaster+2 -2
Revert "Allow querying non-free images too"mediawiki/extensions/PageImagesmaster+98 -315
Customize query in gerrit

Related Objects

Event Timeline

• Deskana created this task.Dec 1 2016, 10:59 PM
Restricted Application added projects: Wikipedia-Android-App-Backlog, Wikipedia-iOS-App-Backlog. · View Herald TranscriptDec 1 2016, 10:59 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
• Deskana triaged this task as Unbreak Now! priority.Dec 1 2016, 10:59 PM
Restricted Application added subscribers: Jay8g, Luke081515, TerraCodes. · View Herald TranscriptDec 1 2016, 10:59 PM
• Deskana added a comment.Dec 1 2016, 11:01 PM

PageImages are still being returned for articles, but they're not showing up in search results on multiple platforms for some reason.

• debt subscribed.Dec 1 2016, 11:07 PM

it seems like when you do only one letter - a few images show up, but if you extend the number of characters, the images all seem to go away

Screen Shot 2016-12-01 at 4.06.12 PM.png (485×418 px, 67 KB)

EBernhardson subscribed.Dec 1 2016, 11:09 PM

Looks to be a problem with pageimages. An example query that should return an image for each, but only returns one:

https://en.wikipedia.org/wiki/Special:ApiSandbox#action=query&format=json&prop=pageimages&titles=Goat+Island+(New+York)%7CGoat+cheese

gerritbot subscribed.Dec 1 2016, 11:09 PM

Change 324826 had a related patch set uploaded (by MaxSem):
Revert "Allow querying non-free images too"

https://gerrit.wikimedia.org/r/324826

gerritbot added a project: Patch-For-Review.Dec 1 2016, 11:09 PM
Smalyshev subscribed.Dec 1 2016, 11:12 PM

Looks like https://gerrit.wikimedia.org/r/#/c/320703/ is the culprit.

Smalyshev added a subscriber: • bmansurov.Dec 1 2016, 11:16 PM
gerritbot added a comment.Dec 1 2016, 11:17 PM

Change 324826 abandoned by MaxSem:
Revert "Allow querying non-free images too"

https://gerrit.wikimedia.org/r/324826

• Deskana added a comment.Dec 1 2016, 11:21 PM

Unfortunately, due to the nature of the error, it seems like the only solution for now that doesn't involve waiting weeks for the pages to be reparsed is to change the default to allow nonfree images. :-/

gerritbot added a comment.Dec 1 2016, 11:22 PM

Change 324827 had a related patch set uploaded (by EBernhardson):
Fix missing page images everywhere

https://gerrit.wikimedia.org/r/324827

• bmansurov added subscribers: Jdlrobson, ovasileva.Dec 1 2016, 11:22 PM
• bmansurov added a comment.Dec 1 2016, 11:33 PM

We could also run the initImageData maintenance script to populate the DB.

Krenair subscribed.Dec 1 2016, 11:54 PM
gerritbot added a comment.Dec 1 2016, 11:58 PM

Change 324838 had a related patch set uploaded (by EBernhardson):
Page images return non-free images by default

https://gerrit.wikimedia.org/r/324838

gerritbot added a comment.Dec 2 2016, 12:06 AM

Change 324827 merged by jenkins-bot:
Page images return non-free images by default

https://gerrit.wikimedia.org/r/324827

Jdlrobson added a comment.Dec 2 2016, 12:11 AM

There is follow up work we'll need to do here.

  1. We'll need to write and get permission to run a maintenance script to run LinksUpdate everywhere. Erik B has pointed out that if a page never gets edited it's page image will never be updated as LinksUpdate will not run.
  2. Switch the default back to free after that has happened.
gerritbot added a comment.Dec 2 2016, 12:16 AM

Change 324838 merged by jenkins-bot:
Page images return non-free images by default

https://gerrit.wikimedia.org/r/324838

Stashbot subscribed.Dec 2 2016, 12:20 AM

Mentioned in SAL (#wikimedia-operations) [2016-12-02T00:20:08Z] <ebernhardson@tin> Synchronized php-1.29.0-wmf.4/extensions/PageImages/includes/ApiQueryPageImages.php: T152155: Thumbnails are not showing in search on multiple platforms (duration: 00m 45s)

• debt added a project: Wikimedia-Portals.Dec 2 2016, 12:21 AM
• Deskana closed this task as Resolved.Dec 2 2016, 12:26 AM
• Deskana assigned this task to EBernhardson.

With the deployment of the above change, the immediate issue is now fixed. The fire has officially been put out. :-) The steps mentioned above by @Jdlrobson still need to be carried out later.

greg added a project: Wikimedia-Incident.Dec 2 2016, 12:42 AM
greg subscribed.

Adding Wikimedia-Incident as this caused a major regression for a period of time for all users.

What does this mean? Someone, probably whoever fixed it or helped, should write up a Incident report: https://wikitech.wikimedia.org/wiki/Incident_documentation

Then, file follow-up tasks to prevent something like this happening in the future within Wikimedia-Incident as well (they'll live in the "follow-up/actionables" column).

Stashbot added a comment.Dec 2 2016, 12:47 AM

Mentioned in SAL (#wikimedia-operations) [2016-12-02T00:47:00Z] <ebernhardson@tin> Synchronized php-1.29.0-wmf.4/extensions/PageImages/maintenance/initImageData.php: T152155: Maintenance script updates for re-initializing page images (duration: 00m 44s)

ReleaseTaggerBot added projects: MW-1.29-release (WMF-deploy-2016-12-06_(1.29.0-wmf.5)), MW-1.29-release (WMF-deploy-2016-11-29_(1.29.0-wmf.4)).Dec 2 2016, 1:00 AM
EBernhardson added a comment.Dec 2 2016, 2:16 AM

maintenance script is running. Max estimated that, based on when this was done to initially populate page images, it will run for a couple weeks.

• bmansurov mentioned this in T152216: Return free images by default.Dec 2 2016, 5:09 PM
gerritbot added a comment.Dec 5 2016, 5:48 PM

Change 325328 had a related patch set uploaded (by EBernhardson):
Add job queue option for initImageData maintenance script

https://gerrit.wikimedia.org/r/325328

Quiddity subscribed.Dec 5 2016, 10:27 PM
In T152155#2840396, @greg wrote:

Adding Wikimedia-Incident as this caused a major regression for a period of time for all users.

What does this mean? Someone, probably whoever fixed it or helped, should write up a Incident report: https://wikitech.wikimedia.org/wiki/Incident_documentation

Was done at https://wikitech.wikimedia.org/wiki/Incident_documentation/20161202-20161201-PageImages

Then, file follow-up tasks to prevent something like this happening in the future within Wikimedia-Incident as well (they'll live in the "follow-up/actionables" column).

Done in

gerritbot added a comment.Dec 6 2016, 7:07 PM

Change 325328 merged by jenkins-bot:
Add job queue option for initImageData maintenance script

https://gerrit.wikimedia.org/r/325328

gerritbot added a comment.Dec 6 2016, 7:09 PM

Change 325602 had a related patch set uploaded (by EBernhardson):
Add job queue option for initImageData maintenance script

https://gerrit.wikimedia.org/r/325602

gerritbot added a comment.Dec 6 2016, 7:09 PM

Change 325602 abandoned by EBernhardson:
Add job queue option for initImageData maintenance script

Reason:
wrong branch

https://gerrit.wikimedia.org/r/325602

gerritbot added a comment.Dec 6 2016, 7:10 PM

Change 325602 restored by EBernhardson:
Add job queue option for initImageData maintenance script

https://gerrit.wikimedia.org/r/325602

gerritbot added a comment.Dec 6 2016, 7:11 PM

Change 325603 had a related patch set uploaded (by EBernhardson):
Add job queue option for initImageData maintenance script

https://gerrit.wikimedia.org/r/325603

gerritbot added a comment.Dec 6 2016, 7:11 PM

Change 325602 abandoned by EBernhardson:
Add job queue option for initImageData maintenance script

https://gerrit.wikimedia.org/r/325602

gerritbot added a comment.Dec 6 2016, 7:11 PM

Change 325605 had a related patch set uploaded (by EBernhardson):
Add job queue option for initImageData maintenance script

https://gerrit.wikimedia.org/r/325605

gerritbot added a comment.Dec 6 2016, 7:12 PM

Change 325606 had a related patch set uploaded (by EBernhardson):
Add job queue option for initImageData maintenance script

https://gerrit.wikimedia.org/r/325606

gerritbot added a comment.Dec 6 2016, 7:13 PM

Change 325603 abandoned by EBernhardson:
Add job queue option for initImageData maintenance script

https://gerrit.wikimedia.org/r/325603

gerritbot added a comment.Dec 6 2016, 7:34 PM

Change 325605 merged by jenkins-bot:
Add job queue option for initImageData maintenance script

https://gerrit.wikimedia.org/r/325605

gerritbot added a comment.Dec 6 2016, 7:34 PM

Change 325606 merged by jenkins-bot:
Add job queue option for initImageData maintenance script

https://gerrit.wikimedia.org/r/325606

Stashbot added a comment.Dec 6 2016, 7:56 PM

Mentioned in SAL (#wikimedia-operations) [2016-12-06T19:56:37Z] <ebernhardson@tin> Synchronized php-1.29.0-wmf.5/extensions/PageImages: T152155: Add job queue option to PageImages initImageData maint script (duration: 00m 45s)

Stashbot added a comment.Dec 6 2016, 7:58 PM

Mentioned in SAL (#wikimedia-operations) [2016-12-06T19:58:39Z] <ebernhardson@tin> Synchronized php-1.29.0-wmf.4/extensions/PageImages: T152155: Add job queue option to PageImages initImageData maint script (duration: 00m 45s)

ReleaseTaggerBot added a project: MW-1.29-release (WMF-deploy-2016-12-13_(1.29.0-wmf.6)).Dec 6 2016, 8:00 PM
Stashbot added a comment.Dec 6 2016, 9:06 PM

Mentioned in SAL (#wikimedia-operations) [2016-12-06T21:06:18Z] <ebernhardson@tin> Synchronized php-1.29.0-wmf.4/extensions/PageImages: T152155: Add job queue option to PageImages initImageData maint script (duration: 00m 46s)

Stashbot added a comment.Dec 6 2016, 9:07 PM

Mentioned in SAL (#wikimedia-operations) [2016-12-06T21:07:30Z] <ebernhardson@tin> Synchronized php-1.29.0-wmf.5/extensions/PageImages: T152155: Add job queue option to PageImages initImageData maint script (duration: 00m 57s)

Blahma mentioned this in T153888: Data disappeared from labs replica in cswiki_p.page_props.Dec 21 2016, 10:50 PM
Gehel edited projects, added Discovery-Search (Current work); removed MW-1.29-release (WMF-deploy-2016-12-13_(1.29.0-wmf.6)), MW-1.29-release (WMF-deploy-2016-11-29_(1.29.0-wmf.4)), Discovery-Search.Feb 11 2025, 3:24 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits