With the roll out of the announcement system, we realized we don't have a good way to test announcements in our beta channel. Suggest we add "-beta" as an option for values in the "platforms" field, and implement display of announcements with that value in the beta versions of the apps.
Description
Description
Details
Details
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| Expand capability and flexibility of Announcements in the feed. | apps/android/wikipedia | master | +67 -10 |
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Declined | None | T152160 Add beta announcement capabilities to apps | |||
| Resolved | LGoto | T191917 Add beta and version targeting announcement capabilities to the iOS app | |||
| Resolved | JoeWalsh | T153224 Consistent consumption of announcements feed endpoint | |||
| Resolved | • Mholloway | T195838 Document the announcement endpoint config parameters | |||
| Resolved | None | T194903 Modify the annoucements cards to accommodate an optional negative/cancel button. |
Event Timeline
Comment Actions
Change 421296 had a related patch set uploaded (by Dbrant; owner: Dbrant):
[apps/android/wikipedia@master] Expand capability and flexibility of Announcements in the feed.
Comment Actions
Change 421296 merged by jenkins-bot:
[apps/android/wikipedia@master] Expand capability and flexibility of Announcements in the feed.
Comment Actions
Done on Android. We now support the following new parameters in the announcement:
- min_version: Minimum app version code for which the announcement should be shown.
- max_version: Maximum app version code for which the announcement should be shown.
- beta: Whether to show the announcement only on pre-production versions of the app.
- logged_in: Whether to show the announcement only to logged-in users or not.
- reading_list_sync_enabled: Whether to show the announcement only if the user has enabled reading list syncing, or not.
- negative_text: Label for the "negative" button on the announcement. If this field is not provided, the button is not shown.
- image_height: The height, in device-independent pixels, of the image portion of the announcement card.
Comment Actions
Also note that the platform string has changed. The Android app now listens to both AndroidApp and AndroidAppV2. See also my comments in T153224#4109135.