Translation review fails for some messages
Closed, InvalidPublic
Actions

Assigned To

None

Authored By

	Kghbln
	Dec 2 2016, 8:54 AM

Description

Originally reported here on twn. The affected messages are:

Smw-pa-property-predefined sci cite key
Smw-pa-property-predefined sci cite reference
Smw-pa-property-predefined sci cite text
Smw-pa-property-predefined sci cite
Smw-pa-property-predefined sci doi
Smw-pa-property-predefined sci pmcid
Smw-pa-property-predefined sci pmid
Smw-pa-property-predefined sci oclc
Smw-pa-property-predefined sci olid
Smw-pa-property-predefined sci viaf

They all belong to the Semantic Cite extension but given the content of the messages I currently do not see a reason why the review should error out as it does now.

--> quick testing link

Reproducing the error:

visiting https://translatewiki.net/wiki/Special:Translate?group=mediawiki
Sliding mouse wheel and clicking Review
checking any of the messages above
a yellow rectangle is shown under check mark

Event Timeline

Kghbln created this task.Dec 2 2016, 8:54 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptDec 2 2016, 8:54 AM

Kghbln added a subscriber: Liuxinyu970226.Dec 2 2016, 8:54 AM

Liuxinyu970226 awarded a token.Dec 2 2016, 2:27 PM

You forgot to include in the task description the steps to reproduce which were included in the thread.

If you follow the link to https://translatewiki.net/w/i.php?title=MediaWiki:Smw-pa-property-predefined_sci_cite_reference/de&action=edit you'll also see that this message is not recognised as existing. In fact en.json has smw-pa-property-predefined__sci_cite_reference. The double space goes against MediaWiki conventions and is not fully supported: maybe the key can be normalised in some more places, maybe the bug will be considered invalid.

This extension seems to have been recently created; you may want to educate the developer about https://www.mediawiki.org/wiki/Manual:Coding_conventions#System_messages to reduce future errors and problems.

Error given is {error: {code: "unknownmessage", info: "Unknown message",…}}.

Did you try whether editing these messages work? There might be something funny with the names, or some stale interim cache.

Did you try whether editing these messages work?

Indeed editing works and gets recorded in the version history. The change as such gets however ignored by the interface.

Kghbln updated the task description. (Show Details)Dec 3 2016, 11:20 AM

You forgot to include in the task description the steps to reproduce which were included in the thread.

This was what the quick test link was meant for since I was able to reproduce by following it. I am sorry that this did not work for you to reproduce. I have now copied the steps into the description.

If you follow the link to https://translatewiki.net/w/i.php?title=MediaWiki:Smw-pa-property-predefined_sci_cite_reference/de&action=edit you'll also see that this message is not recognised as existing. In fact en.json has smw-pa-property-predefined__sci_cite_reference. The double space goes against MediaWiki conventions and is not fully supported: maybe the key can be normalised in some more places, maybe the bug will be considered invalid.

This extension seems to have been recently created; you may want to educate the developer about https://www.mediawiki.org/wiki/Manual:Coding_conventions#System_messages to reduce future errors and problems.

Thanks for your insight. Thus closing as invalid.

Restricted Application removed a subscriber: Liuxinyu970226. · View Herald TranscriptDec 3 2016, 11:23 AM

The change as such gets however ignored by the interface.

I am sorry but this info is incorrect. After editing these messages also vanish from the translation interface.

Translation review fails for some messagesClosed, InvalidPublicActions

Description

Event Timeline

Translation review fails for some messages
Closed, InvalidPublic
Actions