|mediawiki/extensions/PageImages : master||API: return free images by default|
- Mentioned In
- T152239: [2hrs] PageImages code should have documentation warning developers about caching implications
T156203: "FSFileBackend::doPrepareInternal: cannot create directory" on beta cluster
T156169: Update summary to return all images for after Pageimages updates
T156045: Update image request for new license parameter
T147317: Page Previews is allowed to show non-free images
T153888: Data disappeared from labs replica in cswiki_p.page_props
- Mentioned Here
- T156203: "FSFileBackend::doPrepareInternal: cannot create directory" on beta cluster
T152155: Thumbnails are not showing in search on multiple platforms
Yes the maintenance script is finished, should be safe to turn back the other way. Should be verifiable with a few sample api requests by syncing the change to an mwdebug* host after merging, and before syncing out to the wider cluster
Some notable pages that don't have page images:
EDIT: I see an image now.
These pages have images:
These pages should have both free and non-free images, but they don't:
These pages have both free and non-free images:
Given some manual testing I think the patch is ready to be merged given there are no problems with it.
@bmansurov I'm a little confused by your comment and edits. Are these test cases you would like us to test on or are you saying there is something wrong with the current state?
I guess we should merge this post branch cut so we can test more extensively on beta cluster. Do we have a test plan for there?
I wanted to test whether the test scrip correctly finished. Data in production servers seem to be correct. I'm not sure what we would test extensively on beta cluster. If we're worried about data, then we should test API end points on production servers. If we're worried about code, then testing a couple of pages on beta cluster would be enough.
returns no page image.
@Tgr I have a theory that all images used on the beta cluster are not the free license. Do we need to do something on the beta cluster to make this work? It's making me very uncomfortable not being able to see page images on the beta cluster.
Images uploaded to the beta cluster, probably not. You need to add machine-readable metadata to the description page for that, which on Commons is done via the license templates; on beta I doubt anyone bothers.
Images loaded from Commons (which is configured as a remote repo for beta) should work as expected, though.
So I edited Samurai and it now shows (purging had no impact) so @bmansurov you are probably right about the maintenance scripts... so it seems like all pages on the beta cluster would need to be edited (purging not good enough) or a maintenance script would need to be run on the beta cluster to verify this is behaving correctly. @EBernhardson able to help with that? This should not be an issue on production given all pages have now had page images regenerated.
NB: https://en.m.wikipedia.beta.wmflabs.org/wiki/File:Samurai.jpg and https://en.m.wikipedia.beta.wmflabs.org/wiki/File:President_Barack_Obama.jpg are both coming from Commons
Thanks @Tgr for the response. Let me know if you think of anything else.
I have some suspicion beta is misconfigured, but not sure what or how it should be. Since starting the initImageData.php job the jobs are sending messages to logstash like:
FSFileBackend::doPrepareInternal: cannot create directory /srv/mediawiki/php-master/images/thumb/f/f9/Joo_Chia...
- Samurai - any, none, and free are all returning the same image.
- Same as above with San Francisco.
- Star Trek test is returning no image when pilicense is not passed or when its value is free, and returning an image when the license is any.
For future reference, here is the list of test pages. Other pages can be found by searching for a small text in the mobile search overlay and visually inspecting pages that have images.