Page MenuHomePhabricator
Create Task
Maniphest T152241

getLabelWithLang returns wrong lang
Closed, ResolvedPublic
Actions

Description

Executing the following Lua code in hewiki

local label, lang = mw.wikibase.getLabelWithLang( 'Q532055' )

returns

label='Rosaura Revueltas'
lang='he'

(note - the label is in English, which is a fallback)

Expected:

label='Rosaura Revueltas'
lang='en'

Since getLabelWithLang doesn't provide the real language, one must manually validate it doesn't lie by:

mw.wikibase.getEntityObject( "Q532055' ).labels[lang]['language']

Details

SubjectRepoBranchLines +/-
Simplify unused language fallback code in Lua's mw.wikibase.getLabelWithLangmediawiki/extensions/Wikibasemaster+18 -69
Return fallback language code for TermFallback in getLabelWithLangmediawiki/extensions/Wikibasemaster+114 -16
Customize query in gerrit

Related Objects
Search...

StatusSubtypeAssignedTask
 InvalidNoneT112073 Lua in Wikibase (tracking)
 ResolvedaudeT152241 getLabelWithLang returns wrong lang

Event Timeline

eranroz created this task.Dec 2 2016, 8:56 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptDec 2 2016, 8:56 PM
matej_suchanek added a parent task: T112073: Lua in Wikibase (tracking).Dec 6 2016, 11:10 AM
matej_suchanek added a subscriber: hoo.
matej_suchanek added a project: MediaWiki-extensions-WikibaseClient.Dec 12 2016, 2:08 PM
matej_suchanek added subscribers: Lydia_Pintscher, matej_suchanek.

Can anyone look into this? I can confirm that this is bug which influences client wikis.

Lydia_Pintscher added a subscriber: thiemowmde.Dec 13 2016, 10:58 AM

Marius, Thiemo: Can you have a look?

gerritbot subscribed.Dec 13 2016, 2:05 PM

Change 326939 had a related patch set uploaded (by Aude):
Return fallback language code for TermFallback in getLabelWithLang

https://gerrit.wikimedia.org/r/326939

gerritbot added a project: Patch-For-Review.Dec 13 2016, 2:05 PM
aude claimed this task.Dec 13 2016, 2:06 PM
gerritbot added a comment.Dec 13 2016, 2:24 PM

Change 326939 had a related patch set uploaded (by Aude):
Return fallback language code for TermFallback in getLabelWithLang

https://gerrit.wikimedia.org/r/326939

gerritbot added a comment.Dec 13 2016, 3:35 PM

Change 326974 had a related patch set uploaded (by Thiemo Mättig (WMDE)):
Fix language code returned by Lua's mw.wikibase.getLabelWithLang

https://gerrit.wikimedia.org/r/326974

thiemowmde triaged this task as Medium priority.Dec 13 2016, 3:50 PM
thiemowmde added a project: Wikidata-Former-Sprint-Board.
thiemowmde moved this task from incoming to in progress on the Wikidata board.
thiemowmde moved this task from Proposed to Review on the Wikidata-Former-Sprint-Board board.
thiemowmde added a subscriber: aude.
gerritbot added a comment.Dec 13 2016, 4:23 PM

Change 326939 merged by jenkins-bot:
Return fallback language code for TermFallback in getLabelWithLang

https://gerrit.wikimedia.org/r/326939

• Jonas moved this task from Review to Done on the Wikidata-Former-Sprint-Board board.Dec 19 2016, 11:34 AM
gerritbot added a comment.Dec 19 2016, 11:48 AM

Change 326974 merged by jenkins-bot:
Simplify unused language fallback code in Lua's mw.wikibase.getLabelWithLang

https://gerrit.wikimedia.org/r/326974

hoo closed this task as Resolved.Dec 20 2016, 9:20 AM
matej_suchanek removed a project: Patch-For-Review.Mar 24 2017, 5:49 PM
matej_suchanek unsubscribed.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL