Page MenuHomePhabricator

Warnings when loading Special:SpecialPages with CentralAuth installed
Closed, ResolvedPublic

Description

When I try to load Special:SpecialPages locally, I get several warnings including:

Strict standards: Declaration of SpecialGlobalGroupMembership::fetchUser() should be compatible with UserrightsPage::fetchUser($username, $writing = true) in /Users/kaldari/Sites/core/extensions/CentralAuth/includes/specials/SpecialGlobalGroupMembership.php on line 137

Warning: Cannot modify header information - headers already sent by (output started at /Users/kaldari/Sites/core/includes/AutoLoader.php:81) in /Users/kaldari/Sites/core/includes/WebResponse.php on line 45

If I disable CentralAuth, the warnings go away. I'm using the latest master of both core (fb2eaec) and CentralAuth (60a9fb8).

Details

Related Gerrit Patches:

Event Timeline

kaldari created this task.Dec 2 2016, 10:24 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptDec 2 2016, 10:24 PM

Change 328606 had a related patch set uploaded (by Alex Monk):
Adding $writing param to match param signature of parent function

https://gerrit.wikimedia.org/r/328606

Change 328606 merged by jenkins-bot:
Adding $writing param to match param signature of parent function

https://gerrit.wikimedia.org/r/328606

matmarex closed this task as Resolved.Dec 23 2016, 9:02 AM
matmarex assigned this task to kaldari.
matmarex removed a project: Patch-For-Review.

Whoops, thanks for fixing it.