I'm interested in working on this.
@divadsn
If I understand you correctly the task is to move the static html code from Quiz.class.php to Mustache template file and use template parser (server-side) for HTML form or there is something else ?

Hey @divadsn @Mvolz

I started to work on this:

First I have submitted a patch request for another "bug" I found while testing locally: https://gerrit.wikimedia.org/r/#/c/339826/
Then I also began to convert some of the Quiz code in favor of TemplateParser here: https://gerrit.wikimedia.org/r/#/c/339827/ (it works as it should, but some of the legacy code is still there, I will remove and convert that in future patches)

The legacy code is a bit of a mess sometimes so figuring out what does what is not easy.

How should I proceed to get my patch reviewed?

In T152293#3052591, @Harjotsingh wrote:

I'm interested in working on this.
@divadsn
If I understand you correctly the task is to move the static html code from Quiz.class.php to Mustache template file and use template parser (server-side) for HTML form or there is something else ?

Yes, the goal of the task is to completely separate HTML raw code from the PHP code.

In T152293#3055299, @cristianbaldi wrote:

Hey @divadsn @Mvolz

I started to work on this:

First I have submitted a patch request for another "bug" I found while testing locally: https://gerrit.wikimedia.org/r/#/c/339826/
Then I also began to convert some of the Quiz code in favor of TemplateParser here: https://gerrit.wikimedia.org/r/#/c/339827/ (it works as it should, but some of the legacy code is still there, I will remove and convert that in future patches)

The legacy code is a bit of a mess sometimes so figuring out what does what is not easy.

How should I proceed to get my patch reviewed?

Mention this task using "Bug: T152293" after your description, so gerritbot will add your patch for review. But this can be also done manually I think.

Change 339827 had a related patch set uploaded (by Divadsn):
Start implementing Quiz generation using TemplateParser

https://gerrit.wikimedia.org/r/339827

Done, I just edited the commit message for you :)

You can also add reviewers to the patch by clicking the person icon next to "reviewers" on the patch. I've added myself and @Reedy :)

Just a quick question, for further patches (such as porting all the other elements to TemplateParser) should I create new patches/reviews or amend the last one?

In T152293#3055317, @cristianbaldi wrote:

Just a quick question, for further patches (such as porting all the other elements to TemplateParser) should I create new patches/reviews or amend the last one?

That's partially a workflow thing.

If you can keep things in more smaller distinct units, and create patch dependencies where necessary in your commits, this can make code review easier. Certainly, reviewing a patch thoroughly, and then having someone add a load more functionality (that isn't being added because the original patch is wrong) can cause a pain point.

I also asked this on IRC, but I haven't gotten an answer yet:

I did download the review locally which switched me to a new branch "/review/crisbal/improvements/template-parser", I changed the lines that needed a fix, amended the commit and pushed via "git review". Now I want to make some other commits, should I make them on this "review/crisbal/improvements/template-parser" branch or on "improvements/template-parser"?

Also, how should I merge the changes from the "review/crisbal/improvements/template-parser" branch into "improvements/template-parser"?

In T152293#3055965, @cristianbaldi wrote:

I also asked this on IRC, but I haven't gotten an answer yet:

I did download the review locally which switched me to a new branch "/review/crisbal/improvements/template-parser", I changed the lines that needed a fix, amended the commit and pushed via "git review". Now I want to make some other commits, should I make them on this "review/crisbal/improvements/template-parser" branch or on "improvements/template-parser"?

Also, how should I merge the changes from the "review/crisbal/improvements/template-parser" branch into "improvements/template-parser"?

git review -d commitid

i.e. git review -d I7d1ae88 will download the commit,

git commit --amend
git review

and then if you want to do any commits on top of that one, you can checkout a new branch

git checkout -b mynextchange

and put the newest commit there, and then git review that one.

Change 339827 merged by jenkins-bot:
Start implementing Quiz generation using TemplateParser

https://gerrit.wikimedia.org/r/339827

Hey mentors,

is anyone able to code review and merge this? https://gerrit.wikimedia.org/r/#/c/339941/

Thanks!

Answers and Settings both are covered now.
This bug can be resolved now.