Page MenuHomePhabricator

UserProfile: Convert Special:RemoveAvatar to OOUI + HTMLForm
Closed, ResolvedPublic

Assigned To
Authored By
SamanthaNguyen
Dec 3 2016, 10:37 PM
Referenced Files
F16829464: befire.JPG
Apr 8 2018, 3:16 PM
F16829462: after.JPG
Apr 8 2018, 3:16 PM
F16673820: before.JPG
Apr 4 2018, 9:46 PM
F16672666: before.JPG
Apr 4 2018, 9:46 PM
F16672665: after.JPG
Apr 4 2018, 9:46 PM
F16674796: after.JPG
Apr 4 2018, 9:46 PM

Description

Screenshots by @Jayprakash12345

Special:RemoveAvatar

BeforeAfter
before.JPG (636×1 px, 51 KB)
after.JPG (637×1 px, 58 KB)

Special:RemoveAvatar/{username}

BeforeAfter
before.JPG (643×1 px, 55 KB)
after.JPG (636×1 px, 51 KB)

OnSucess

BeforeAfter
befire.JPG (642×1 px, 58 KB)
after.JPG (635×1 px, 56 KB)

Event Timeline

SamanthaNguyen renamed this task from Convert SocialProfile UserProfile Special:RemoveAvatar to OOJS-UI HTMLForm to UserProfile: Convert Special:RemoveAvatar to OOUI + HTMLForm.Apr 4 2018, 9:43 PM

@Jayprakash12345 Thanks for creating this sort of task again! I had to merge it as a duplicate again which is no problem, just make sure to look through existing tasks in the future :) I'll be reviewing this patch soon!

Also for the record, I'd like to say I agree with @Volker_E's comment on the semantic use of the destructive button.

Change 423947 had a related patch set uploaded (by Jayprakash12345; owner: Jayprakash12345):
[mediawiki/extensions/SocialProfile@master] Convert Special:RemoveAvatar/{username} to OOUI

https://gerrit.wikimedia.org/r/423947

Change 423928 had a related patch set uploaded (by Jayprakash12345; owner: Jayprakash12345):
[mediawiki/extensions/SocialProfile@master] Partially Convert Special:RemoveAvatar to OOUI

https://gerrit.wikimedia.org/r/423928

Jayprakash12345 triaged this task as Medium priority.

Change 423947 merged by jenkins-bot:
[mediawiki/extensions/SocialProfile@master] Convert Special:RemoveAvatar/{username} to OOUI

https://gerrit.wikimedia.org/r/423947

Change 423928 merged by jenkins-bot:
[mediawiki/extensions/SocialProfile@master] Partially Convert Special:RemoveAvatar to OOUI

https://gerrit.wikimedia.org/r/423928

Change 424858 had a related patch set uploaded (by Jayprakash12345; owner: Jayprakash12345):
[mediawiki/extensions/SocialProfile@master] Make success msg little bit stylish

https://gerrit.wikimedia.org/r/424858

Jayprakash12345 added a subscriber: gerritbot.

Change 424858 had a related patch set uploaded (by Jayprakash12345; owner: Jayprakash12345):
[mediawiki/extensions/SocialProfile@master] Make success msg little bit stylish

https://gerrit.wikimedia.org/r/424858

This has merged. We remove this from this task because it is related to UI, not OOUI or HTMLForm.

Sorry :)