Page MenuHomePhabricator
Create Task
Maniphest T152359

Remove Special:Newsletter/id/delete forms completely form Newsletter interface
Closed, ResolvedPublic
Actions

Description

We are not going to use Special:Newsletter/id/delete anymore, and sticking on to the 'Delete' option from the main newsletter page (Top right, More -> Delete).

The task would involve:

  1. Removing the 'Delete' from the subtitles in Special:Newsletter/id/actions
  2. Removing the form and other stuff from the codebase.

Splitting it into two tasks, to make it easier for a GCI task.

Details

SubjectRepoBranchLines +/-
Remove Special:Newsletter/id/delete forms completely from Newsletter interfacemediawiki/extensions/Newslettermaster+7 -164
Customize query in gerrit

Related Objects
Search...

Event Timeline

01tonythomas created this task.Dec 4 2016, 11:42 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptDec 4 2016, 11:42 PM
01tonythomas created subtask T152360: Remove 'delete' option from Special:Newsletter/id/actions subtitles.Dec 4 2016, 11:43 PM
01tonythomas created subtask T152361: Remove 'delete' forms and other code from Newsletter codebase.
gerritbot subscribed.Dec 5 2016, 2:47 AM

Change 325249 had a related patch set uploaded (by MtDu):
Remove Special:Newsletter/id/delete forms completely from Newsletter interface

https://gerrit.wikimedia.org/r/325249

gerritbot added a project: Patch-For-Review.Dec 5 2016, 2:47 AM
01tonythomas added a comment.Dec 5 2016, 10:11 PM

We still havent got this imported in GCI site yet ! :-(

01tonythomas merged a task: T149649: Upon deleting a newsletter, do not show the subtitle navigation on top .Dec 6 2016, 1:50 PM
01tonythomas added subscribers: MtDu, Devirk, Florian and 7 others.

This task is imported as https://codein.withgoogle.com/dashboard/tasks/6220680376877056/

gerritbot added a comment.Dec 7 2016, 12:26 AM

Change 325249 merged by jenkins-bot:
Remove Special:Newsletter/id/delete forms completely from Newsletter interface

https://gerrit.wikimedia.org/r/325249

MtDu closed this task as Resolved.Dec 7 2016, 1:26 AM
MtDu claimed this task.

Finished in https://gerrit.wikimedia.org/r/325249. :)

MtDu closed subtask T152360: Remove 'delete' option from Special:Newsletter/id/actions subtitles as Resolved.Dec 7 2016, 1:27 AM
MtDu closed subtask T152361: Remove 'delete' forms and other code from Newsletter codebase as Resolved.
Qgil awarded a token.Dec 7 2016, 10:54 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL