Page MenuHomePhabricator

Use comms.http.fetch() for LinkChecker in weblinkchecker
Closed, DeclinedPublic

Description

Currently pywikibot.comms.http.fetch() provides the ability to make HTTP requests (using pywikibot.comms.threadedhttp module), and its use_fake_user_agent arguments allows the usage of fake user agents, which can be beneficial for checking external websites. It would be therefore nice to replace the currently used httplib with fetch().

Event Timeline

T113140 was the previous effort to use requests.

jayvdb subscribed.

Ah, my apologies. As mentioned in T113140 , LinkChecker is deprecated and is not used by LinkCheckThread or WeblinkCheckerRobot , so the decision was to leave that code as-is.