Page MenuHomePhabricator

Retrofit NearbyFetchTask
Closed, ResolvedPublic

Description

  • Refactor NearbyFetchTask into NearbyClient using CaptchaClient as an example
  • Add NearbyClientTest using CaptchaClientTest as an example

This task isn't quite "Easy" but it's a good candidate for volunteer contributors looking to get more familiar with the codebase, MediaWiki API, and unit tests

Event Timeline

Mholloway renamed this task from Retrofit fetching nearby articles to Retrofit NearbyFetchTask.Dec 5 2016, 3:07 PM
Mholloway claimed this task.

@Mholloway, I added slightly more detail and marked this task as Easy. I think our data client patterns are starting to become clear enough that a volunteer contributor, espeically a second or third time contributor, could pick this one up reasonably well

Change 317292 had a related patch set uploaded (by Mholloway):
Retrofit NearbyFetchTask

https://gerrit.wikimedia.org/r/317292

Change 332354 had a related patch set uploaded (by Mholloway):
Add NearbyClientTest

https://gerrit.wikimedia.org/r/332354

Change 317292 merged by jenkins-bot:
Retrofit NearbyFetchTask

https://gerrit.wikimedia.org/r/317292

Change 332354 merged by jenkins-bot:
Add NearbyClientTest

https://gerrit.wikimedia.org/r/332354

Mholloway removed a project: good first task.

Removing "Easy" since this one actually turned out to be rather thorny.

Reopening for QA (please test to ensure the Nearby feature continues to work normally).

Device details
Model : Samsung-SM-J120A (Galaxy Express 3)
Android : 6.0.1
App version : 2.4.184-alpha-2017-01-24

This is fixed as the Nearby feature is working as expected.