super setUp()s and tearDown()s in unit test cases
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Dargasea
	Dec 5 2016, 6:45 PM

Project Tags

Referenced Files

None

Subscribers

Description

Currently some test cases in the tests folder, like tests.http_tests.TestGetAuthenticationConfig, inherit from tests.aspects.TestCase, but do not super the parent's setUp and tearDown.

Details

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	Unit tests should use super setUp and tearDown when appropriate	pywikibot/core	master	+9 -0

Customize query in gerrit

Event Timeline

Dargasea created this task.Dec 5 2016, 6:45 PM

Restricted Application added subscribers: pywikibot-bugs-list, TerraCodes, Aklapper. · View Herald TranscriptDec 5 2016, 6:45 PM

Dargasea triaged this task as Low priority.Dec 5 2016, 6:45 PM

@jayvdb

created by your request :) . You can import this into GCI when you get the chance.

Dargasea updated the task description. (Show Details)Dec 5 2016, 10:01 PM

Nice description.

Thanks! Imported as https://codein.withgoogle.com/tasks/6476392277475328/

Sn1per claimed this task.Dec 18 2016, 5:49 AM

Change 328060 had a related patch set uploaded (by Sn1per):
Unit tests should use super setUp and tearDown when appropriate

https://gerrit.wikimedia.org/r/328060

gerritbot added a project: Patch-For-Review.Dec 18 2016, 8:49 PM

Dargasea unsubscribed.Dec 19 2016, 1:45 AM

Magul closed this task as Resolved.Dec 19 2016, 5:38 PM

Change 328060 merged by jenkins-bot:
Unit tests should use super setUp and tearDown when appropriate

https://gerrit.wikimedia.org/r/328060

super setUp()s and tearDown()s in unit test casesClosed, ResolvedPublicActions

Description

Details

Event Timeline

super setUp()s and tearDown()s in unit test cases
Closed, ResolvedPublic
Actions