[Task] Split EntityTitleLookup interface into actual "Title" and "Entity store" lookups
Closed, ResolvedPublic
Actions

Description

Originally these patches where part of T148626: [Task] EntityIdValues should be formatted as local wiki links in Wikitext output, but got blocked with -1 and removed from the chain of patches I build intentionally, and T148626 got closed without looking back at these patches.

Patches for review:

Subject	Repo	Branch	Lines +/-
Use EntityTitleStoreLookup where necesarry	mediawiki/extensions/Wikibase	master	+80 -80
Remove misplaced namespace lookup method from EntityTitleStoreLookup	mediawiki/extensions/Wikibase	master	+18 -15
Split EntityTitleLookup interface	mediawiki/extensions/Wikibase	master	+117 -42

		Status	Subtype	Assigned	Task
		Resolved		thiemowmde	T152498 [Task] Split EntityTitleLookup interface into actual "Title" and "Entity store" lookups
		Resolved		thiemowmde	T148626 [Task] EntityIdValues should be formatted as local wiki links in Wikitext output

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptDec 6 2016, 1:44 PM

thiemowmde triaged this task as High priority.Dec 6 2016, 1:45 PM

Change 328490 had a related patch set uploaded (by Thiemo Mättig (WMDE)):
Remove misplaced namespace lookup method from EntityTitleStoreLookup

Change 316977 had a related patch set uploaded (by Thiemo Mättig (WMDE)):
Split EntityTitleLookup interface

Change 316977 merged by jenkins-bot:
Split EntityTitleLookup interface

Change 328632 had a related patch set uploaded (by Thiemo Mättig (WMDE)):
Use EntityTitleStoreLookup where necesarry

Change 328490 merged by jenkins-bot:
Remove misplaced namespace lookup method from EntityTitleStoreLookup

Change 328632 merged by jenkins-bot:
Use EntityTitleStoreLookup where necesarry

All patches (and some more) listed in the task description are now merged. Is there more that should be done here or is this resolved?

thiemowmde updated the task description. (Show Details)