<noinclude>, <includeonly> and <onlyinclude> in ALL CAPS result in errors now
Closed, ResolvedPublic

Description

Author: wiki.bugzilla

Description:

  1. Please add e.g. <NOINCLUDE>foo</NOINCLUDE> or simply <NOINCLUDE> (yes, ALL CAPS instead of lower case) on any random page and try to safe. This only results in the following error, also on preview (it's not possible to safe the change):

Invalid call hook noinclude
Backtrace:
#0 /usr/local/apache/common-local/php-1.5/includes/Preprocessor_DOM.php(960): Parser->extensionSubstitution(Array, Object(PPFrame_DOM))
#1 /usr/local/apache/common-local/php-1.5/includes/Parser.php(2641): PPFrame_DOM->expand(Object(PPNode_DOM), 0)
#2 /usr/local/apache/common-local/php-1.5/includes/Parser.php(941): Parser->replaceVariables('<NOINCLUDE>??')
#3 /usr/local/apache/common-local/php-1.5/includes/Parser.php(311): Parser->internalParse('<NOINCLUDE>??')
#4 /usr/local/apache/common-local/php-1.5/includes/EditPage.php(1548): Parser->parse('<NOINCLUDE>??', Object(Title), Object(ParserOptions))
#5 /usr/local/apache/common-local/php-1.5/includes/EditPage.php(1157): EditPage->getPreviewText()
#6 /usr/local/apache/common-local/php-1.5/includes/EditPage.php(474): EditPage->showEditForm()
#7 /usr/local/apache/common-local/php-1.5/includes/EditPage.php(342): EditPage->edit()
#8 /usr/local/apache/common-local/php-1.5/includes/Wiki.php(445): EditPage->submit()
#9 /usr/local/apache/common-local/php-1.5/includes/Wiki.php(48): MediaWiki->performAction(Object(OutputPage), Object(Article), Object(Title), Object(User), Object(WebRequest))
#10 /usr/local/apache/common-local/php-1.5/index.php(90): MediaWiki->initialize(Object(Title), Object(OutputPage), Object(User), Object(WebRequest))
#11 /usr/local/apache/common-local/live-1.5/index.php(3): require('/usr/local/apac...')
#12 {main}

This is generally the same for <INCLUDEONLY> and <ONLYINCLUDE>.

  1. This problem is pretty new as you can see from the following case:

Please first have a look at this diff
http://de.wikipedia.org/w/index.php?title=Wikipedia:Verbesserungsvorschl%C3%A4ge/Feature-Requests/Archiv/2007&diff=43297074&oldid=42760361
and then click on the previous revision (you can't access it directly atm, only by adding &action=edit; preview fails too).
The relevant edit by [[de:User:W!B:]] (who originally added <NOINCLUDE> to the page [[de:Wikipedia:Verbesserungsvorschläge/Feature-Requests]]) dates back to 2007-01-08 - more than one year ago, see
http://de.wikipedia.org/w/index.php?title=Wikipedia:Verbesserungsvorschl%C3%A4ge/Feature-Requests&oldid=26123468 (also not accessible atm).
Since then the page has been edited more than 400 times. All the versions between January 2007 and February 20, 2008 are currently not accessible.
On 2008-02-20 a bot successfully archived the section in question, see http://de.wikipedia.org/w/index.php?title=Wikipedia:Verbesserungsvorschläge/Feature-Requests&diff=42760320&oldid=42759625
The error was first noticed on 2008-03-04 on de.wikipedia.

I assume that there are dozens of pages or old revisions on the wikis that are affected by this issue.

Note: The expected behaviour for all caps forms of <noinclude> etc. is that they get ignored.


Version: 1.13.x
Severity: normal
URL: http://de.wikipedia.org/w/index.php?title=Wikipedia:Verbesserungsvorschl%C3%A4ge/Feature-Requests/Archiv/2007&diff=43297074&oldid=42760361

bzimport set Reference to bz13253.
bzimport created this task.Via LegacyMar 5 2008, 12:31 AM
brion added a comment.Via ConduitMar 5 2008, 12:46 AM

Can confirm the lovely fatal exception...

Assigning to Tim for investigation.

tstarling added a comment.Via ConduitMar 5 2008, 1:19 AM

Fixed in r31564.

Add Comment

Column Prototype
This is a very early prototype of a persistent column. It is not expected to work yet, and leaving it open will activate other new features which will break things. Press "\" (backslash) on your keyboard to close it now.