Page MenuHomePhabricator
Create Task
Maniphest T152547

[Regression pre-wmf.6] Cannot save any edit with VisualEditor getting error "The parameters "page" and "oldid" can not be used together."
Closed, ResolvedPublic1 Estimated Story Points
Actions

Description

Cannot save any edit with VisualEditor getting error "The parameters "page" and "oldid" can not be used together."

Screen Shot 2016-12-06 at 3.51.18 PM.png (351×511 px, 63 KB)

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
ApiVisualEditorEdit: ApiParse ignores 'page' when 'oldid' is suppliedmediawiki/extensions/VisualEditormaster+2 -3
Customize query in gerrit

Related Objects

Event Timeline

Ryasmeen created this task.Dec 6 2016, 8:53 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptDec 6 2016, 8:53 PM
Ryasmeen renamed this task from Cannot save any edit with VisualEditor getting error "The parameters "page" and "oldid" can not be used together." to [Regression pre-wmf.6] Cannot save any edit with VisualEditor getting error "The parameters "page" and "oldid" can not be used together.".Dec 6 2016, 8:56 PM
matmarex added a project: MediaWiki-Action-API.Dec 6 2016, 9:21 PM
matmarex added subscribers: Anomie, matmarex.

Caused by 4e6810e4a2c1d821d8d108c7974ac16917561764 – ApiParse.php now has stricter checks. https://gerrit.wikimedia.org/r/#/c/321406/15/includes/api/ApiParse.php

gerritbot subscribed.Dec 6 2016, 9:37 PM

Change 325641 had a related patch set uploaded (by Anomie):
ApiVisualEditorEdit: ApiParse ignores 'page' when 'oldid' is supplied

https://gerrit.wikimedia.org/r/325641

gerritbot added a project: Patch-For-Review.Dec 6 2016, 9:37 PM
Jdforrester-WMF moved this task from To Triage to TR0: Interrupt on the VisualEditor board.Dec 7 2016, 1:43 AM
Anomie moved this task from Unsorted to Needs Review on the MediaWiki-Action-API board.Dec 7 2016, 3:34 PM
gerritbot added a comment.Dec 8 2016, 3:07 AM

Change 325641 merged by jenkins-bot:
ApiVisualEditorEdit: ApiParse ignores 'page' when 'oldid' is supplied

https://gerrit.wikimedia.org/r/325641

ReleaseTaggerBot added a project: MW-1.29-release (WMF-deploy-2016-12-13_(1.29.0-wmf.6)).Dec 8 2016, 4:00 AM
Anomie added a comment.Dec 8 2016, 4:25 PM

I'm pretty sure this is fixed now, but I can't easily test it in Beta Labs thanks to T152663: Gerrit not updating submodules in mediawiki/extensions.

• demon subscribed.Dec 8 2016, 5:26 PM
In T152547#2857251, @Anomie wrote:

I'm pretty sure this is fixed now, but I can't easily test it in Beta Labs thanks to T152663: Gerrit not updating submodules in mediawiki/extensions.

You can always manually bump the submodule in the meta repo.

Jdforrester-WMF closed this task as Resolved.Dec 10 2016, 3:00 AM
Jdforrester-WMF assigned this task to Anomie.
Jdforrester-WMF triaged this task as Unbreak Now! priority.
Jdforrester-WMF set the point value for this task to 1.
Jdforrester-WMF removed a project: Patch-For-Review.

I manually bumped all the submodules in the meta repo in rMEXT200b1bba109937207361ca73dc10ca416f98f4bc and it appears fixed. Thanks Brad!

Restricted Application added subscribers: Jay8g, TerraCodes. · View Herald TranscriptDec 10 2016, 3:00 AM
Ryasmeen added a project: Verified.Dec 13 2016, 5:49 PM
Aklapper removed a subscriber: Anomie.Oct 16 2020, 5:38 PM
Restricted Application added a project: User-Ryasmeen. · View Herald TranscriptOct 16 2020, 5:38 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits