Page MenuHomePhabricator
Create Task
Maniphest T152605

MassEditRegex extension / Fatal error: Call to undefined method SkinVector::commentBlock()
Closed, ResolvedPublic
Actions

Description

Setup

  • MediaWiki 1.28.0 (e92ed15) 22:16, 28. Nov. 2016
  • PHP 5.6.27-0+deb8u1 (apache2handler)
  • MariaDB 10.0.28-MariaDB-1~jessie
  • MassEditRegex 8.1.1 (f6c7ea5) 15:56, 29. Okt. 2016

Issue
When trying to access special page "MassEditRegex" the extension errors out with:

Fatal error: Call to undefined method SkinVector::commentBlock() in /.../w/extensions/MassEditRegex/MassEditRegex.special.php on line 363

or

Fatal error: Call to undefined method SkinMonoBook::commentBlock() in /.../w/extensions/MassEditRegex/MassEditRegex.special.php on line 363

depending on which skin one is using.

This is an error starting with MW 1.28.0, the MW 1.27 branch is not affected. Originally reported on MediaWiki.org.

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Replace deprecated skin's commentBlock function with Linker::commentBlockmediawiki/extensions/MassEditRegexREL1_27+1 -1
Replace deprecated skin's commentBlock function with Linker::commentBlockmediawiki/extensions/MassEditRegexREL1_28+1 -1
Replace deprecated skin's commentBlock function with Linker::commentBlockmediawiki/extensions/MassEditRegexmaster+1 -1
Customize query in gerrit

Related Objects

Event Timeline

Kghbln created this task.Dec 7 2016, 2:14 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptDec 7 2016, 2:14 PM
Kghbln updated the task description. (Show Details)Dec 7 2016, 2:17 PM
Paladox added a comment.Dec 7 2016, 2:25 PM

I belive that it is calling a deprecated function if I am right that it is using Linker, it was moved into a different class, but it has two functions now, one is a static and one is just a function that is deprecated.

Kghbln added a comment.Dec 7 2016, 2:31 PM
In T152605#2854028, @Paladox wrote:

I belive that it is calling a deprecated function if I am right that it is using Linker, it was moved into a different class, but it has two functions now, one is a static and one is just a function that is deprecated.

Thanks for your insight on this. I am willing to test in case you would like to give it a shot at fixing.

Paladox added a comment.Dec 7 2016, 2:32 PM

I think I know how to fix this. I found the function was deperecated in skins.php, but I doint know why it is calling SkinVector::.

gerritbot subscribed.Dec 7 2016, 2:35 PM

Change 325780 had a related patch set (by Paladox) published:
Replace deprecated skin's commentBlock function with Linker::commentBlock

https://gerrit.wikimedia.org/r/325780

gerritbot added a project: Patch-For-Review.Dec 7 2016, 2:35 PM
Paladox added a comment.Dec 7 2016, 2:36 PM

@Kghbln hi would you be able to test the above please? I doint know if it will have any other side effects or if that is the right code to be replaced with.

Kghbln added a comment.Dec 7 2016, 2:38 PM
In T152605#2854067, @Paladox wrote:

I think I know how to fix this. I found the function was deperecated in skins.php, but I doint know why it is calling SkinVector::.

For large edit tasks this extension also allows to execute the script in the browser itself which is useful if you want to avoid timeouts from direct script execution via the special page. I suppose that's the reason why there is some interaction with Vector and MonoBook which is probably also broken.

Kghbln updated the task description. (Show Details)Dec 7 2016, 2:39 PM
gerritbot added a comment.Dec 7 2016, 4:18 PM

Change 325799 had a related patch set uploaded (by Kghbln):
Replace deprecated skin's commentBlock function with Linker::commentBlock

https://gerrit.wikimedia.org/r/325799

Paladox added a comment.Dec 7 2016, 4:24 PM
This comment was removed by Paladox.
gerritbot added a comment.Dec 7 2016, 4:27 PM

Change 325801 had a related patch set uploaded (by Kghbln):
Replace deprecated skin's commentBlock function with Linker::commentBlock

https://gerrit.wikimedia.org/r/325801

Kghbln assigned this task to Paladox.Dec 7 2016, 4:52 PM
Kghbln triaged this task as High priority.
Kghbln updated the task description. (Show Details)
gerritbot added a comment.Dec 8 2016, 6:34 PM

Change 325780 merged by jenkins-bot:
Replace deprecated skin's commentBlock function with Linker::commentBlock

https://gerrit.wikimedia.org/r/325780

Kghbln closed this task as Resolved.Dec 8 2016, 7:56 PM

Though the backports to REL1_27 and REL1_28 have not yet been merged this task can already be closed since we at least have version 8.2.0! Great work and tanks to @Paladox

Paladox merged a task: T153557: Extension:MassEditRegex branch REL1_28 is incompatible with MW 1.28.Dec 17 2016, 9:29 PM
Paladox added a subscriber: labster.
Aklapper merged a task: T153557: Extension:MassEditRegex branch REL1_28 is incompatible with MW 1.28.Dec 18 2016, 9:02 AM
NDKilla subscribed.Dec 18 2016, 11:01 PM

@Kghbln Any insight as to when REL1_28 backport might get merged?

We automatically pull it and the extension basically doesn't work as is. The task 'extension branch rel1_28 is not compatible with mw 1.28' isn't just reporting the issue that caused it to be incompatible. Until the backport is actually merged and people can pull branch x and have it work with branch x of mediawiki, im going to say that the repeatedly merged issue is still valid. Extension branch 1.28 should work with mediawiki 1.28.

Kghbln added a comment.EditedDec 18 2016, 11:04 PM

Any insight as to when REL1_28 backport might get merged?

By experience this can take every time between one hour and one month. However version 8.2.0 is authored and tagged so you can pull this on since it contains the necessary fix for MW 1.28+

gerritbot added a comment.Dec 18 2016, 11:07 PM

Change 325799 merged by jenkins-bot:
Replace deprecated skin's commentBlock function with Linker::commentBlock

https://gerrit.wikimedia.org/r/325799

gerritbot added a comment.Dec 18 2016, 11:07 PM

Change 325801 merged by jenkins-bot:
Replace deprecated skin's commentBlock function with Linker::commentBlock

https://gerrit.wikimedia.org/r/325801

NDKilla added a comment.Dec 18 2016, 11:08 PM

Speak of the devil :p
Thanks guys

Kghbln added a subscriber: Reedy.Dec 18 2016, 11:10 PM
In T152605#2885490, @NDKilla wrote:

Speak of the devil :p
Thanks guys

So three weeks is within the timeframe I guess. ;) I believe you triggered something. :)

@Reedy Thanks a lot!

Kghbln removed a project: Patch-For-Review.Dec 18 2016, 11:11 PM
Reedy added a comment.Dec 18 2016, 11:13 PM
In T152605#2885491, @Kghbln wrote:
In T152605#2885490, @NDKilla wrote:

Speak of the devil :p
Thanks guys

So three weeks is within the timeframe I guess. ;) I believe you triggered something. :)

@Reedy Thanks a lot!

FYI @Kghbln it's generally considered ok to CR+2 patches (whether it's your own patch, or someone else's cherry picked by you) when they're cherry picks to release branches to fix bugs

Paladox added a comment.Dec 18 2016, 11:51 PM

Thanks.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits