Page MenuHomePhabricator

Update UploadWizard for recent API error message changes
Closed, ResolvedPublic


Recently merged probably breaks like a dozen things in UploadWizard (the announcement mentions action=upload in particular). We should go through all of our error handling code and verify what still works right and what needs fixing. Also, we need to do this before next week's deployment. :/

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

@matthiasmullie Thanks for taking this. Can I help somehow?

Not at this point, and it doesn't seem like much (if anything) will be broken - BC is quite good. But I'm sure I can use some help in testing of all kinds of possible errors next week :p

Change 326134 had a related patch set uploaded (by Matthias Mullie):
[WIP] Simplify error handling

So, just to be clear, we don't actually have any compatibility issues at the moment, and we don't need to do anything before the deployment? This probably doesn't have to be "High" priority then.

It looks like I actually misread the warning in the announcement:

action=upload now reports optional stash failures as an array under key 'stasherrors' rather than a 'stashfailed' text string.

This talks about optional stash failures, which is something we don't use (it's about the case where you try to upload and publish the file with a single action=upload, and you get an error which prevents publishing but allows the file to be stashed; if the stashing also fails, that's called an optional stash failure). We do uploading and publishing in separate action=upload queries.

matthiasmullie lowered the priority of this task from High to Medium.Dec 13 2016, 11:10 AM

Yeah, nothing seems to be broken at this point, BC is good. I'm working on using the new error formats, but it's not too urgent.

Change 328373 had a related patch set uploaded (by Matthias Mullie):
Use parsed error messages straight from API

Change 328373 merged by jenkins-bot:
Use parsed error messages straight from API