Page MenuHomePhabricator

Refactor eventlogging.pp role into multiple files (and maybe get rid of inheritance)
Closed, ResolvedPublic5 Estimated Story Points

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Ottomata moved this task from Next Up to In Progress on the Analytics-Kanban board.
Ottomata changed the point value for this task from 8 to 5.

Change 325838 had a related patch set uploaded (by Ottomata):
Refactor eventlogging analytics role classes into many files

https://gerrit.wikimedia.org/r/325838

Change 325838 merged by Ottomata:
Refactor eventlogging analytics role classes into many files

https://gerrit.wikimedia.org/r/325838

Change 325936 had a related patch set uploaded (by Ottomata):
role eventlogging::consumer::files -> eventlogging::analytics::files

https://gerrit.wikimedia.org/r/325936

Change 325936 merged by Ottomata:
role eventlogging::consumer::files -> eventlogging::analytics::files

https://gerrit.wikimedia.org/r/325936

Change 325940 had a related patch set uploaded (by Ottomata):
Apply role::eventlogging::analytics::zeromq

https://gerrit.wikimedia.org/r/325940

Change 325940 merged by Ottomata:
Apply role::eventlogging::analytics::{zeromq,mysql,processor}

https://gerrit.wikimedia.org/r/325940

Change 325948 had a related patch set uploaded (by Ottomata):
Remove now unused eventlogging.pp role

https://gerrit.wikimedia.org/r/325948

Change 325948 merged by Ottomata:
Remove now unused eventlogging.pp role

https://gerrit.wikimedia.org/r/325948

Change 326083 had a related patch set uploaded (by Elukey):
Remove the role eventlogging from site.pp

https://gerrit.wikimedia.org/r/326083

Change 326083 merged by Elukey:
Remove the role eventlogging from site.pp

https://gerrit.wikimedia.org/r/326083

Change 326085 had a related patch set uploaded (by Elukey):
Add the eventlogging admins back to eventlog1001

https://gerrit.wikimedia.org/r/326085

Change 326085 merged by Elukey:
Add the eventlogging admins back to eventlog1001

https://gerrit.wikimedia.org/r/326085

Last action left: removing unnecessary hiera data belonging to the eventlogging role (that is removed).

I see that we have role/common/eventlogging.yaml adding admin groups, eventlogging-admins and eventlogging-roots on hosts via the role. This has to be moved to one of the new roles or people in that admin group won't have shell access in the future (on newly installed hosts).

I see that we have role/common/eventlogging.yaml adding admin groups, eventlogging-admins and eventlogging-roots on hosts via the role. This has to be moved to one of the new roles or people in that admin group won't have shell access in the future (on newly installed hosts).

I already did it with https://gerrit.wikimedia.org/r/#/c/326085, we need to cleanup :)

ah, ok! (Let's keep using roles to add admin groups instead of host names though. It means less edits in the future)

I agree, it was a temporary measure to fix the immediate issue of the eventlogging role not present anymore but listed in site.pp. Since the eventlogging role became multiple ones and I didn't know which one should have got the admin hiera configs..