Page MenuHomePhabricator
Create Task
Maniphest T152663

Gerrit not updating submodules in mediawiki/extensions
Closed, ResolvedPublic
Actions

Description

Beta cluster hasn't picked up any new code for any of the extensions for the past 11 hours. Thanks @bd808 for investigating!

It looks like the mediawiki/extensions repo hasn't been updated since the Gerrit upgrade

Details

Related Changes in Gerrit:
Show related patches Customize query in gerrit

Related Objects

Event Timeline

Yurik created this task.Dec 8 2016, 5:41 AM
Restricted Application added subscribers: Jay8g, Luke081515, TerraCodes, Aklapper. · View Herald TranscriptDec 8 2016, 5:41 AM
Legoktm renamed this task from Beta-cluster not updating extensions to Gerrit not updating submodules in mediawiki/extensions.Dec 8 2016, 5:42 AM
Legoktm edited projects, added: Gerrit; removed: Beta-Cluster-Infrastructure.
Legoktm updated the task description. (Show Details)
Legoktm added a subscriber: • demon.
Legoktm subscribed.Dec 8 2016, 6:28 AM

Debugged with @demon on IRC:

Caused by: https://www.gerritcodereview.com/releases/2.13.md#Access-control-for-git-submodule-subscriptions

Updated config: https://gerrit.wikimedia.org/r/325884 https://gerrit.wikimedia.org/r/325885

Merged a dummy patch in mediawiki/extensions/examples, didn't work.

Merged a dummy patch in mediawiki/examples to touch the repo, and then merged a patch in mediawiki/extensions/ExtensionDistributor, still didn't work.

Called it a night for now.

Paladox subscribed.Dec 8 2016, 8:41 AM
gerritbot subscribed.Dec 8 2016, 9:12 AM

Change 325898 had a related patch set (by Paladox) published:
Allow mw/core and mw/extensions and mw/skins to subscribe to all extensions

https://gerrit.wikimedia.org/r/325898

gerritbot added a project: Patch-For-Review.Dec 8 2016, 9:12 AM
Anomie subscribed.Dec 8 2016, 4:23 PM
gerritbot added a comment.Dec 8 2016, 4:24 PM

Change 325898 merged by Chad:
Allow mw/core and mw/extensions and mw/skins to subscribe to all extensions

https://gerrit.wikimedia.org/r/325898

Anomie mentioned this in T152547: [Regression pre-wmf.6] Cannot save any edit with VisualEditor getting error "The parameters "page" and "oldid" can not be used together.".Dec 8 2016, 4:25 PM
Paladox added a comment.Dec 8 2016, 5:25 PM

I think this is a bug. I have been trying all day on two test sites and they are not working. running gerrit 2.13 too.

gerritbot added a comment.Dec 9 2016, 11:59 PM

Change 326200 had a related patch set (by Paladox) published:
Fix submodules not auto updating

https://gerrit.wikimedia.org/r/326200

gerritbot added a comment.Dec 10 2016, 12:04 AM

Change 326201 had a related patch set (by Paladox) published:
Fix submodules not auto updating

https://gerrit.wikimedia.org/r/326201

gerritbot added a comment.Dec 10 2016, 12:07 AM

Change 326201 merged by Chad:
Fix submodules not auto updating

https://gerrit.wikimedia.org/r/326201

gerritbot added a comment.Dec 10 2016, 12:18 AM

Change 326207 had a related patch set (by Paladox) published:
Fix submodules not auto updating

https://gerrit.wikimedia.org/r/326207

gerritbot added a comment.Dec 10 2016, 12:19 AM

Change 326207 merged by Chad:
Fix submodules not auto updating

https://gerrit.wikimedia.org/r/326207

Paladox added a comment.EditedDec 10 2016, 12:36 PM

@demon could you try a reindex please as one of my test installs did not use subscribe and it started working, I belive it may be because we need to do a reindex (not sure if it should be a full reindex) but it is like when you had to reindex a change because the change was showing as still open on the dashbored but was actually merged.

Maybe an reindex will fix things.

we should probably go with a full reindex since it seems we have to keep reindexing changes after changes. If a full reindex does not stop us having to reindex changes then I would think this is a bug.

Paladox added a comment.Dec 10 2016, 5:12 PM

I've figured out how to fix this, I am going to submit a patch to fix one submodule to try the fix, but I did try this on my local install and I could reproduce why this didn't work and then figured out how to fix it :)

gerritbot added a comment.Dec 10 2016, 5:15 PM

Change 326276 had a related patch set uploaded (by Paladox):
Fix the Example submodule

https://gerrit.wikimedia.org/r/326276

gerritbot added a comment.Dec 11 2016, 12:17 AM

Change 326276 merged by Chad:
Fix the Example submodule

https://gerrit.wikimedia.org/r/326276

Paladox added a comment.EditedDec 11 2016, 12:26 AM

@demon Yay it is fixed.

https://phabricator.wikimedia.org/rSKINe46fdca14c8b2dc4e02e11149875d99643655907

Needs a mass migration now.

gerritbot added a comment.Dec 11 2016, 12:33 AM

Change 326294 had a related patch set uploaded (by Paladox):
Mass migrate skins to fix submodules

https://gerrit.wikimedia.org/r/326294

gerritbot added a comment.Dec 11 2016, 12:34 AM

Change 326294 merged by Chad:
Mass migrate skins to fix submodules

https://gerrit.wikimedia.org/r/326294

gerritbot added a comment.Dec 11 2016, 12:36 AM

Change 326295 had a related patch set (by Paladox) published:
Mass migrate extensions to fix submodules

https://gerrit.wikimedia.org/r/326295

gerritbot added a comment.Dec 11 2016, 1:04 AM

Change 326295 merged by Chad:
Mass migrate extensions to fix submodules

https://gerrit.wikimedia.org/r/326295

Paladox added a comment.Dec 11 2016, 1:10 AM

@demon extensions submodules now work

https://phabricator.wikimedia.org/rMEXT3e1ad50e44a3866863f920bd504b0f516ba131cc

:)

gerritbot added a comment.Dec 11 2016, 2:34 AM

Change 326301 had a related patch set uploaded (by Paladox):
Mass migrate extensions to fix submodules (1.28)

https://gerrit.wikimedia.org/r/326301

gerritbot added a comment.Dec 11 2016, 2:34 AM

Change 326302 had a related patch set uploaded (by Paladox):
Mass migrate extensions to fix submodules (1.27)

https://gerrit.wikimedia.org/r/326302

gerritbot added a comment.Dec 11 2016, 2:35 AM

Change 326303 had a related patch set uploaded (by Paladox):
Mass migrate extensions to fix submodules (1.23)

https://gerrit.wikimedia.org/r/326303

Paladox lowered the priority of this task from Unbreak Now! to High.Dec 11 2016, 1:31 PM

Changing to high as the problem looks fixed, we can close this tommror as resolved if no other problem pops up.

gerritbot added a comment.Dec 12 2016, 9:00 AM

Change 326301 merged by Hashar:
Mass migrate extensions to fix submodules (1.28)

https://gerrit.wikimedia.org/r/326301

gerritbot added a comment.Dec 12 2016, 9:00 AM

Change 326302 merged by Hashar:
Mass migrate extensions to fix submodules (1.27)

https://gerrit.wikimedia.org/r/326302

gerritbot added a comment.Dec 12 2016, 9:01 AM

Change 326303 merged by Hashar:
Mass migrate extensions to fix submodules (1.23)

https://gerrit.wikimedia.org/r/326303

hashar closed this task as Resolved.Dec 12 2016, 9:07 AM
hashar assigned this task to Paladox.

@Paladox got it fixed by changing the git URLs:

- https://gerrit.wikimedia.org/r/p/PROJECT.git
+ https://gerrit.wikimedia.org/r/PROJECT

That is most probably related to Gerrit 2.13 access control for submodules (release notes).

Their documentation mentions:

ensure the .gitmodules file of the super project includes
...
a branch field

a url that starts with the gerrit.canonicalWebUrl

And we have:

manifests/jetty.pp:    $url = "https://${::gerrit::host}/r",
templates/gerrit.config.erb:    canonicalWebUrl = <%= @url %>

Thus our /r/p/.*\.git URLs were not recognized/matched by Gerrit.

gerritbot added a comment.Dec 12 2016, 9:15 AM

Change 326399 had a related patch set uploaded (by Paladox):
Mass migrate skins to fix submodules

https://gerrit.wikimedia.org/r/326399

gerritbot added a comment.Dec 12 2016, 9:18 AM

Change 326399 merged by Hashar:
Mass migrate skins to fix submodules

https://gerrit.wikimedia.org/r/326399

gerritbot added a comment.Dec 12 2016, 9:23 AM

Change 326400 had a related patch set (by Paladox) published:
Mass migrate skins to fix submodules

https://gerrit.wikimedia.org/r/326400

gerritbot added a comment.Dec 12 2016, 9:47 AM

Change 326400 merged by Hashar:
Mass migrate skins to fix submodules

https://gerrit.wikimedia.org/r/326400

gerritbot added a comment.Dec 13 2016, 2:28 PM

Change 326947 had a related patch set uploaded (by Hashar):
Fix submodules URL for Gerrit syncronisation

https://gerrit.wikimedia.org/r/326947

gerritbot added a comment.Dec 15 2016, 1:30 AM

Change 326947 merged by Chad:
Fix submodules URL for Gerrit syncronisation

https://gerrit.wikimedia.org/r/326947

ReleaseTaggerBot added a project: MW-1.29-release (WMF-deploy-2016-12-06_(1.29.0-wmf.5)).Dec 15 2016, 2:00 AM
Aklapper removed a subscriber: Anomie.Oct 16 2020, 5:40 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits