Page MenuHomePhabricator

Gerrit not updating submodules in mediawiki/extensions
Closed, ResolvedPublic

Description

Beta cluster hasn't picked up any new code for any of the extensions for the past 11 hours. Thanks @bd808 for investigating!

It looks like the mediawiki/extensions repo hasn't been updated since the Gerrit upgrade

Event Timeline

Legoktm renamed this task from Beta-cluster not updating extensions to Gerrit not updating submodules in mediawiki/extensions.Dec 8 2016, 5:42 AM
Legoktm edited projects, added Gerrit; removed Beta-Cluster-Infrastructure.
Legoktm updated the task description. (Show Details)
Legoktm added a subscriber: demon.

Debugged with @demon on IRC:

Caused by: https://www.gerritcodereview.com/releases/2.13.md#Access-control-for-git-submodule-subscriptions

Updated config: https://gerrit.wikimedia.org/r/325884 https://gerrit.wikimedia.org/r/325885

Merged a dummy patch in mediawiki/extensions/examples, didn't work.

Merged a dummy patch in mediawiki/examples to touch the repo, and then merged a patch in mediawiki/extensions/ExtensionDistributor, still didn't work.

Called it a night for now.

Change 325898 had a related patch set (by Paladox) published:
Allow mw/core and mw/extensions and mw/skins to subscribe to all extensions

https://gerrit.wikimedia.org/r/325898

Change 325898 merged by Chad:
Allow mw/core and mw/extensions and mw/skins to subscribe to all extensions

https://gerrit.wikimedia.org/r/325898

I think this is a bug. I have been trying all day on two test sites and they are not working. running gerrit 2.13 too.

Change 326200 had a related patch set (by Paladox) published:
Fix submodules not auto updating

https://gerrit.wikimedia.org/r/326200

Change 326201 had a related patch set (by Paladox) published:
Fix submodules not auto updating

https://gerrit.wikimedia.org/r/326201

Change 326201 merged by Chad:
Fix submodules not auto updating

https://gerrit.wikimedia.org/r/326201

Change 326207 had a related patch set (by Paladox) published:
Fix submodules not auto updating

https://gerrit.wikimedia.org/r/326207

Change 326207 merged by Chad:
Fix submodules not auto updating

https://gerrit.wikimedia.org/r/326207

@demon could you try a reindex please as one of my test installs did not use subscribe and it started working, I belive it may be because we need to do a reindex (not sure if it should be a full reindex) but it is like when you had to reindex a change because the change was showing as still open on the dashbored but was actually merged.

Maybe an reindex will fix things.

we should probably go with a full reindex since it seems we have to keep reindexing changes after changes. If a full reindex does not stop us having to reindex changes then I would think this is a bug.

I've figured out how to fix this, I am going to submit a patch to fix one submodule to try the fix, but I did try this on my local install and I could reproduce why this didn't work and then figured out how to fix it :)

Change 326276 had a related patch set uploaded (by Paladox):
Fix the Example submodule

https://gerrit.wikimedia.org/r/326276

Change 326276 merged by Chad:
Fix the Example submodule

https://gerrit.wikimedia.org/r/326276

Change 326294 had a related patch set uploaded (by Paladox):
Mass migrate skins to fix submodules

https://gerrit.wikimedia.org/r/326294

Change 326294 merged by Chad:
Mass migrate skins to fix submodules

https://gerrit.wikimedia.org/r/326294

Change 326295 had a related patch set (by Paladox) published:
Mass migrate extensions to fix submodules

https://gerrit.wikimedia.org/r/326295

Change 326295 merged by Chad:
Mass migrate extensions to fix submodules

https://gerrit.wikimedia.org/r/326295

Change 326301 had a related patch set uploaded (by Paladox):
Mass migrate extensions to fix submodules (1.28)

https://gerrit.wikimedia.org/r/326301

Change 326302 had a related patch set uploaded (by Paladox):
Mass migrate extensions to fix submodules (1.27)

https://gerrit.wikimedia.org/r/326302

Change 326303 had a related patch set uploaded (by Paladox):
Mass migrate extensions to fix submodules (1.23)

https://gerrit.wikimedia.org/r/326303

Paladox lowered the priority of this task from Unbreak Now! to High.Dec 11 2016, 1:31 PM

Changing to high as the problem looks fixed, we can close this tommror as resolved if no other problem pops up.

Change 326301 merged by Hashar:
Mass migrate extensions to fix submodules (1.28)

https://gerrit.wikimedia.org/r/326301

Change 326302 merged by Hashar:
Mass migrate extensions to fix submodules (1.27)

https://gerrit.wikimedia.org/r/326302

Change 326303 merged by Hashar:
Mass migrate extensions to fix submodules (1.23)

https://gerrit.wikimedia.org/r/326303

hashar assigned this task to Paladox.

@Paladox got it fixed by changing the git URLs:

- https://gerrit.wikimedia.org/r/p/PROJECT.git
+ https://gerrit.wikimedia.org/r/PROJECT

That is most probably related to Gerrit 2.13 access control for submodules (release notes).

Their documentation mentions:

ensure the .gitmodules file of the super project includes
...
a branch field

a url that starts with the gerrit.canonicalWebUrl

And we have:

manifests/jetty.pp:    $url = "https://${::gerrit::host}/r",
templates/gerrit.config.erb:    canonicalWebUrl = <%= @url %>

Thus our /r/p/.*\.git URLs were not recognized/matched by Gerrit.

Change 326399 had a related patch set uploaded (by Paladox):
Mass migrate skins to fix submodules

https://gerrit.wikimedia.org/r/326399

Change 326399 merged by Hashar:
Mass migrate skins to fix submodules

https://gerrit.wikimedia.org/r/326399

Change 326400 had a related patch set (by Paladox) published:
Mass migrate skins to fix submodules

https://gerrit.wikimedia.org/r/326400

Change 326400 merged by Hashar:
Mass migrate skins to fix submodules

https://gerrit.wikimedia.org/r/326400

Change 326947 had a related patch set uploaded (by Hashar):
Fix submodules URL for Gerrit syncronisation

https://gerrit.wikimedia.org/r/326947

Change 326947 merged by Chad:
Fix submodules URL for Gerrit syncronisation

https://gerrit.wikimedia.org/r/326947