Fixed in r31761.

brianna.laugher wrote:

Thankyou Alex, but could it please be more standard... like

$wgOut->addHTML( '<div id="uploadfooter">' );
$wgOut->addWikiText???( wfMsg???( 'uploadfooter' ) );
$wgOut->addHTML( "</div>\n" );

instead of

$uploadfooter = wfMsgNoTrans( 'uploadfooter' );
if( $uploadfooter != '-' && !wfEmptyMsg( 'uploadfooter', $uploadfooter ) ){

     $wgOut->addWikiText( $uploadfooter );
}

It should be translateable, so I'm pretty sure wfMsgNoTrans is wrong. And it should be able to contain
HTML.

thankyou.

It is translatable, wfMsgNoTrans doesn't mean what you think. Also, we don't add new messages that can contain HTML.

But there is no class or id around it, which might be something that should be fixed.

brianna.laugher wrote:

(In reply to comment #3)

It is translatable, wfMsgNoTrans doesn't mean what you think. Also, we don't
add new messages that can contain HTML.

Does <div> count as HTML? Well, obviously, but I suppose, does it count as wikitext? Because that's actually what I want to use.

But there is no class or id around it, which might be something that should be
fixed.

And also, please remove the checking about if the message is defined. If the message is not defined, it should just end up as an empty div.

In the current implementation, transclusions and embedded HTML (<span>s, or <div>s) do work. Just redirects don't, but that can be worked around using a transclusion.

I think the only fixes needed here would be to wrap the message in an identifying <div id="wpUploadfooter"> (or a similar ID), and is the checking for empty or dash really needed?

(In reply to comment #5)

I think the only fixes needed here would be to wrap the message in an
identifying <div id="wpUploadfooter"> (or a similar ID), and is the checking
for empty or dash really needed?

Yes. Added id in r32033.