Page MenuHomePhabricator

[BUG] News detail images are extremely low quality
Closed, ResolvedPublic

Description

Steps to reproduce

  1. In the explore feed, tap on an item in the "In the news" section that has an image
  2. Observe the image at the top of the detail view

Expected results

Gallery res image

Actual results

Thumbnail res image

Consider fetching the full article and using the lead image.

Event Timeline

NHarateh_WMF subscribed.

This task should be a subtask of Image Cache bucket task.

Or, at least, the fix from https://phabricator.wikimedia.org/T152167 would fix this issue as well.

@Mhurd since that issue is specifically about requesting lower quality thumbnails for the feed, and this one is specifically about requesting higher quality images for in the news, I think they should remain separate. If you'd rather convert the other issue to include this problem (or about requesting the correct image size more generally) I could see it being duped against it.

@JoeWalsh

Oh I may have been less than clear on the other ticket - it's about safely requesting the most appropriate resolution for each feed item - this can encompass requesting either a higher or lower resolution image, though most cases will indeed be changed to request lower resolutions. Thanks to T152163 we now can now do this :)

ABorbaWMF subscribed.

Tested on an iPhone 7+ with iOS 10.3 and an iPad Mini 2 Retina with iOS 10.2 both running App 5.4.1.1112

Images look good.