Page MenuHomePhabricator
Create Task
Maniphest T152797

Attribute RC lines to their sources
Closed, ResolvedPublic
Actions

Description

When rendering lines tag them with classes, e.g. "Experienced", "Your edits", "Completed review".

Needs to be extensible for e.g. ORES.

Details

SubjectRepoBranchLines +/-
Back-end of new RecentChanges page, refactoringmediawiki/coremaster+4 K -1 K
Add highlight classes if a model is enabledmediawiki/extensions/ORESmaster+11 -5
Add classes to RC lines so they can be highlightedmediawiki/extensions/ORESmaster+107 -24
Add classes to RC lines so they can be highlightedmediawiki/coremaster+103 -4
Customize query in gerrit

Related Objects

Event Timeline

• Mattflaschen-WMF created this task.Dec 9 2016, 7:27 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptDec 9 2016, 7:27 PM
Aklapper added a project: Edit-Review-Improvements-RC-Page.Dec 9 2016, 7:39 PM
Restricted Application added a project: Collaboration-Team-Triage. · View Herald TranscriptDec 9 2016, 7:39 PM
• Mattflaschen-WMF mentioned this in T149385: Approved interface text for RC page interface elements.Dec 9 2016, 11:40 PM
• Mattflaschen-WMF mentioned this in T152754: Configure filters in a single extensible place.Dec 12 2016, 6:16 PM
gerritbot subscribed.Dec 13 2016, 5:43 PM

Change 327006 had a related patch set uploaded (by Sbisson):
[WIP] Add classes to RC lines so they can be highlighted

https://gerrit.wikimedia.org/r/327006

gerritbot added a project: Patch-For-Review.Dec 13 2016, 5:43 PM

Change 327007 had a related patch set uploaded (by Sbisson):
[WIP] Add classes to RC lines so they can be highlighted

https://gerrit.wikimedia.org/r/327007

• jmatazzoni edited projects, added Collaboration-Team-Triage (Collab-Team-Q2-Oct-Dec-2016); removed Collaboration-Team-Triage.Dec 13 2016, 7:51 PM
• jmatazzoni moved this task from Untriaged to Needs Review on the Collaboration-Team-Triage (Collab-Team-Q2-Oct-Dec-2016) board.
SBisson moved this task from Needs Review to In Development on the Collaboration-Team-Triage (Collab-Team-Q2-Oct-Dec-2016) board.Dec 14 2016, 1:49 PM
SBisson moved this task from In Development to Needs Review on the Collaboration-Team-Triage (Collab-Team-Q2-Oct-Dec-2016) board.Jan 4 2017, 10:03 PM
• jmatazzoni edited projects, added Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017); removed Collaboration-Team-Triage (Collab-Team-Q2-Oct-Dec-2016).Jan 5 2017, 10:41 PM
• jmatazzoni moved this task from Untriaged to Blocked on the Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017) board.Jan 5 2017, 10:46 PM
SBisson moved this task from Blocked to Needs Review on the Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017) board.Jan 6 2017, 7:54 PM
gerritbot added a comment.Feb 14 2017, 2:18 PM

Change 327006 abandoned by Sbisson:
Add classes to RC lines so they can be highlighted

Reason:
Now included in https://gerrit.wikimedia.org/r/#/c/337048

https://gerrit.wikimedia.org/r/327006

Catrope closed this task as Resolved.Feb 23 2017, 10:21 PM
gerritbot added a comment.Mar 7 2017, 5:19 PM

Change 327007 merged by jenkins-bot:
[mediawiki/extensions/ORES] Add classes to RC lines so they can be highlighted

https://gerrit.wikimedia.org/r/327007

ReleaseTaggerBot added a project: MW-1.29-release (WMF-deploy-2017-03-07_(1.29.0-wmf.15)).Mar 7 2017, 6:00 PM
gerritbot added a comment.Mar 7 2017, 8:11 PM

Change 341596 had a related patch set uploaded (by Sbisson):
[mediawiki/extensions/ORES] Add highlight classes if a model is enabled

https://gerrit.wikimedia.org/r/341596

gerritbot added a comment.Mar 7 2017, 9:44 PM

Change 341596 merged by jenkins-bot:
[mediawiki/extensions/ORES] Add highlight classes if a model is enabled

https://gerrit.wikimedia.org/r/341596

ReleaseTaggerBot added a project: MW-1.29-release (WMF-deploy-2017-03-14_(1.29.0-wmf.16)).Mar 7 2017, 10:00 PM
gerritbot added a comment.Mar 9 2017, 3:09 PM

Change 337546 had a related patch set uploaded (by Mattflaschen):
[mediawiki/core] Back-end of new RecentChanges page, refactoring

https://gerrit.wikimedia.org/r/337546

gerritbot added a comment.Mar 11 2017, 1:55 AM

Change 337546 merged by jenkins-bot:
[mediawiki/core] Back-end of new RecentChanges page, refactoring

https://gerrit.wikimedia.org/r/337546

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL