Page MenuHomePhabricator
Create Task
Maniphest T152813

File histories won't display more than 10 files on a page
Closed, ResolvedPublic
Actions

Description

File histories won't display more than 10 files on a page. Looks like I broke it with https://gerrit.wikimedia.org/r/#/c/323547/ (f94d5239b528c406c85e090152805a1306e13ded). Example: https://commons.wikimedia.org/w/index.php?title=File:ElectoralCollege2016.svg&offset=&limit=500#filehistory

Details

SubjectRepoBranchLines +/-
ImageHistoryPseudoPager: Don't ignore limit from URLmediawiki/corewmf/1.29.0-wmf.5+3 -1
ImageHistoryPseudoPager: Don't ignore limit from URLmediawiki/coremaster+3 -1
Customize query in gerrit

Related Objects

Event Timeline

matmarex created this task.Dec 9 2016, 11:22 PM
Restricted Application added projects: Multimedia, Commons. · View Herald TranscriptDec 9 2016, 11:22 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
gerritbot subscribed.Dec 11 2016, 7:30 PM

Change 326361 had a related patch set uploaded (by Bartosz Dziewoński):
ImageHistoryPseudoPager: Don't ignore limit from URL

https://gerrit.wikimedia.org/r/326361

Restricted Application added a subscriber: Matanya. · View Herald TranscriptDec 11 2016, 7:30 PM
gerritbot added a project: Patch-For-Review.Dec 11 2016, 7:30 PM
matmarex added a comment.Dec 11 2016, 8:49 PM

https://commons.wikimedia.org/w/index.php?title=Commons:Help_desk&oldid=225902593#Only_showing_10_file_revisions

Poyekhali awarded a token.Dec 12 2016, 11:03 AM
gerritbot added a comment.Dec 12 2016, 6:43 PM

Change 326361 merged by jenkins-bot:
ImageHistoryPseudoPager: Don't ignore limit from URL

https://gerrit.wikimedia.org/r/326361

gerritbot added a comment.Dec 12 2016, 6:48 PM

Change 326497 had a related patch set uploaded (by Bartosz Dziewoński):
ImageHistoryPseudoPager: Don't ignore limit from URL

https://gerrit.wikimedia.org/r/326497

ReleaseTaggerBot added projects: MW-1.29-release-notes, MW-1.29-release (WMF-deploy-2016-12-13_(1.29.0-wmf.6)).Dec 12 2016, 7:00 PM
gerritbot added a comment.Dec 12 2016, 7:38 PM

Change 326497 merged by jenkins-bot:
ImageHistoryPseudoPager: Don't ignore limit from URL

https://gerrit.wikimedia.org/r/326497

Stashbot subscribed.Dec 12 2016, 7:56 PM

Mentioned in SAL (#wikimedia-operations) [2016-12-12T19:56:25Z] <thcipriani@tin> Synchronized php-1.29.0-wmf.5/includes/page/ImageHistoryPseudoPager.php: SWAT: [[gerrit:326497|ImageHistoryPseudoPager: Do not ignore limit from URL]] T152813 (duration: 00m 45s)

matmarex closed this task as Resolved.Dec 12 2016, 7:57 PM
matmarex removed a project: Patch-For-Review.

Fixed and deployed.

ReleaseTaggerBot added a project: MW-1.29-release (WMF-deploy-2016-12-06_(1.29.0-wmf.5)).Dec 12 2016, 8:00 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL