Page MenuHomePhabricator

RelatedArticles should not depend on EventLogging
Closed, ResolvedPublic

Description

Right now a wiki has to have EventLogging installed to use RelatedArticles but shouldn't. This is unfair on 3rd parties who may want to use this without EventLogging or for developers who are confused about why this should use EventLogging. It should be a soft dependency.

Event Timeline

Jdlrobson triaged this task as Medium priority.Dec 13 2016, 6:10 PM
Jdlrobson moved this task from Incoming to Upcoming on the Web-Team-Backlog-Archived board.

@ovasileva this might have been (partially) fixed with change-id I55cf4f40cafc88d6baeb5cc1b41fc2d6bcd2fbb9 as done under T157375

Although that uses class_exists( 'EventLogging' ), which probably should be replaced with \ExtensionRegistry::getInstance()->isLoaded( 'EventLogging' )

Jdlrobson claimed this task.
Jdlrobson added a subscriber: bmansurov.

Yup this is fixed. I disabled EventLogging and sure enough related pages works fine. I'm not sure about the time frame here and when and how it got broken as the patch from @bmansurov in rERAR3995b7a8ef84: Add event logging to read more precedes the creation of this task.