Page MenuHomePhabricator

Refactor Translate $1 Insertable classes
Closed, ResolvedPublic


Several translatewiki projects use $1, $2, $3, etc. as a parameter format. They should all use the same Insertable class, and it should be in the Translate extension rather than in the translatewiki repository.

Some projects, like MediaWiki and its extensions, use $1 and also {{GENDER}}, {{PLURAL}}, $letters (for tvar), etc.
If it's possible to put $1 in one class and the other insertables in other classes and then use them all, it would be nice, but not a requirement for this task. It's enough to get all the projects that need only $1 to use the same class.

@Aklapper, this can be done in Google-Code-In-2016.

Event Timeline

Amire80 created this task.Dec 10 2016, 1:03 PM
Restricted Application added a subscriber: TerraCodes. · View Herald TranscriptDec 10 2016, 1:03 PM

This task is a bit difficult to understand. Can you put in an example please ?

Change 329803 had a related patch set uploaded (by Sn1per):
Insertables suggester class for numerical parameters

Change 329806 had a related patch set uploaded (by Sn1per):
Replace redundant numeric parameter insertables suggesters

Sn1per claimed this task.Jan 1 2017, 5:56 AM

Change 329803 merged by jenkins-bot:
[mediawiki/extensions/Translate@master] Insertables suggester class for $1, $2 and allow multiple suggesters

Change 329806 merged by jenkins-bot:
[translatewiki@master] Replace redundant numeric parameter insertables suggesters

Nikerabbit closed this task as Resolved.Apr 7 2017, 10:25 AM
Nikerabbit removed a project: Patch-For-Review.

Apologies for review taking too long.