Page MenuHomePhabricator
Create Task
Maniphest T152913

RevisionSlider lazy loading causes arrow on bar to load on wrong side in RTL
Closed, ResolvedPublic
Actions

Description

Report at : https://www.mediawiki.org/wiki/Topic:Tgznmfaazl6ba68c

Hi. Something happened, and now the RS opening arrow is on the right side of the screen instead of usual left. When clicking, the arrow "jumps" back to the left side.

Without looking at the code I am 99% sure that this is is due to the lazy loading patch https://gerrit.wikimedia.org/r/#/c/323193/

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Load bar arrow on left for RTL languagesmediawiki/extensions/RevisionSliderwmf/1.29.0-wmf.6+2 -1
Load bar arrow on left for RTL languagesmediawiki/extensions/RevisionSlidermaster+2 -1
Load bar arrow on left for RTL languagesmediawiki/extensions/RevisionSliderwmf/1.29.0-wmf.5+2 -1
Customize query in gerrit

Related Objects

Event Timeline

Addshore created this task.Dec 11 2016, 3:39 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptDec 11 2016, 3:39 PM
Reedy added a project: Revision-Slider.Dec 11 2016, 3:40 PM
Restricted Application added a project: TCB-Team (now WMDE-TechWish). · View Herald TranscriptDec 11 2016, 3:40 PM
IKhitron added a subscriber: Guycn2.Dec 11 2016, 3:41 PM
IKhitron subscribed.
Addshore added a project: Regression.Dec 11 2016, 3:51 PM
Addshore added a project: RTL.
Restricted Application added a project: I18n. · View Herald TranscriptDec 11 2016, 3:51 PM
Addshore added a project: WMDE-TechWish.Dec 11 2016, 3:51 PM
Addshore removed subscribers: WMDE-TechWish, Revision-Slider, Regression.
Addshore moved this task from Proposed to Todo on the WMDE-TechWish board.Dec 11 2016, 3:59 PM
Addshore claimed this task.Dec 12 2016, 6:30 PM
Addshore moved this task from Todo to Sprint ready on the WMDE-TechWish board.
gerritbot subscribed.Dec 12 2016, 6:46 PM

Change 326494 had a related patch set uploaded (by Addshore):
Load bar arrow on left for RTL languages

https://gerrit.wikimedia.org/r/326494

gerritbot added a project: Patch-For-Review.Dec 12 2016, 6:46 PM
Addshore added a project: User-Addshore.Dec 12 2016, 6:47 PM
Addshore moved this task from Unsorted 💣 to Active 🚁 on the User-Addshore board.
gerritbot added a comment.Dec 12 2016, 6:48 PM

Change 326495 had a related patch set uploaded (by Addshore):
Load bar arrow on left for RTL languages

https://gerrit.wikimedia.org/r/326495

Addshore mentioned this in rERSL387274edd1ac: Load bar arrow on left for RTL languages.Dec 12 2016, 6:49 PM
Addshore mentioned this in rERSLddc7415601da: Load bar arrow on left for RTL languages.
gerritbot added a comment.Dec 12 2016, 7:00 PM

Change 326495 abandoned by Addshore:
Load bar arrow on left for RTL languages

Reason:
no longer swatting

https://gerrit.wikimedia.org/r/326495

WMDE-leszek subscribed.Dec 13 2016, 5:10 PM
Tobi_WMDE_SW mentioned this in rERSLa21c58676247: Load bar arrow on left for RTL languages.Dec 14 2016, 10:38 AM
gerritbot added a comment.Dec 14 2016, 12:19 PM

Change 326494 merged by jenkins-bot:
Load bar arrow on left for RTL languages

https://gerrit.wikimedia.org/r/326494

Tobi_WMDE_SW closed this task as Resolved.Dec 14 2016, 12:34 PM
Tobi_WMDE_SW moved this task from Sprint ready to Done on the WMDE-TechWish board.
Tobi_WMDE_SW moved this task from Incoming to Revision Slider on the TCB-Team (now WMDE-TechWish) board.Dec 14 2016, 12:37 PM
ReleaseTaggerBot added a project: MW-1.29-release (WMF-deploy-2017-01-03_(1.29.0-wmf.7)).Dec 14 2016, 1:00 PM
gerritbot added a comment.Dec 15 2016, 10:59 AM

Change 327475 had a related patch set uploaded (by Addshore):
Load bar arrow on left for RTL languages

https://gerrit.wikimedia.org/r/327475

Addshore mentioned this in rERSL4877fa7733fa: Load bar arrow on left for RTL languages.Dec 15 2016, 10:59 AM
Addshore moved this task from Active 🚁 to Closing ✔️ on the User-Addshore board.Dec 15 2016, 11:46 AM
Addshore mentioned this in rERSL304a6c2e5274: Load bar arrow on left for RTL languages.Dec 15 2016, 1:42 PM
gerritbot added a comment.Dec 15 2016, 2:19 PM

Change 327475 merged by jenkins-bot:
Load bar arrow on left for RTL languages

https://gerrit.wikimedia.org/r/327475

Addshore added a comment.Dec 15 2016, 2:32 PM

Also backported onto the wmf6 branch now which should be deployed to everywhere this evening!

ReleaseTaggerBot added a project: MW-1.29-release (WMF-deploy-2016-12-13_(1.29.0-wmf.6)).Dec 15 2016, 3:00 PM
Tobi_WMDE_SW moved this task from Incoming to Done on the Revision-Slider board.Dec 16 2016, 10:35 AM
Tobi_WMDE_SW moved this task from Done to Demoed on the WMDE-TechWish board.Dec 20 2016, 12:10 PM
Tobi_WMDE_SW removed projects: MW-1.29-release (WMF-deploy-2016-12-13_(1.29.0-wmf.6)), WMDE-TechWish.Jun 7 2017, 12:01 PM
thiemowmde removed a project: TCB-Team (now WMDE-TechWish).Jan 7 2022, 3:07 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits