Page MenuHomePhabricator

Commenting on a merged patch does not send the notification to irc
Closed, ResolvedPublic

Description

Steps to reproduce

  • Comment on a patch that is merged.
  • Go to irc and watch feed

Actual results

  • It does not send any notifications to irc any more.

Expected results

  • I expect that it should send the comment to irc even if the patch is merged.

This problem started in gerrit 2.13.

*Upstream report: https://bugs.chromium.org/p/gerrit/issues/detail?id=5116

Event Timeline

Paladox created this task.Dec 11 2016, 11:07 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptDec 11 2016, 11:07 PM
Paladox updated the task description. (Show Details)Dec 11 2016, 11:08 PM
Paladox added a project: Upstream.
Paladox moved this task from Backlog to Reported Upstream on the Upstream board.

What is "it" in "It does not send any notifications to irc any more"? gerrit-wm?

It sends notifications as long as the patch is open, when you merge it and comment on the patch it dosent send that to irc any more (grrrit-wm)

@demon I tested stream-events + a test bot with gerrit.git.wmflabs.org and commenting on a merged change works there.

Strange that it dosent work on prod. Could it be catching / need a reindex?

Pro stream-event

{"author":{"name":"Paladox","email":"thomasmulhall410@yahoo.com","username":"paladox"},"comment":"Patch Set 20:\n\ntest","patchSet":{"number":"20","revision":"2b805d7222d7e2418c12ad420cd61140121ffabd","parents":["034d960f0568029001e333ec46a7f75d6167db30"],"ref":"refs/changes/40/323540/20","uploader":{"name":"Hashar","email":"hashar@free.fr","username":"hashar"},"createdOn":1481621929,"author":{"name":"Paladox","email":"thomasmulhall410@yahoo.com","username":"paladox"},"isDraft":false,"kind":"TRIVIAL_REBASE","sizeInsertions":192,"sizeDeletions":-94},"change":{"project":"integration/config","branch":"master","id":"Icad88b9b0995199eb3e75b9e5ce9f7a0acfee16e","number":"323540","subject":"Support skin as dependencies","owner":{"name":"Paladox","email":"thomasmulhall410@yahoo.com","username":"paladox"},"url":"https://gerrit.wikimedia.org/r/323540","commitMessage":"Support skin as dependencies\n\nRename Zuul method set_ext_dependencies to a more generic\nset_mw_dependencies\n\nDependent skins are injected via a new SKIN_DEPENDENCIES variable. We\nonly need to clone the repositories, the MediaWiki installer takes care\nof injecting/installing them in LocalSettings.php unlike extensions that\nrely on extensions_load.txt.\n\nRefactor/enhance tests to take skins in account.\nAdd a few tests for get_dependencies()\n\nBug: T151593\nSigned-off-by: Antoine Musso \u003chashar@free.fr\u003e\nChange-Id: Icad88b9b0995199eb3e75b9e5ce9f7a0acfee16e\n","status":"MERGED"},"project":"integration/config","refName":"refs/heads/master","changeKey":{"id":"Icad88b9b0995199eb3e75b9e5ce9f7a0acfee16e"},"type":"comment-added","eventCreatedOn":1481657607}

test stream-event

{"author":{"name":"Paladox","email":"thomasmulhall410@yahoo.com","username":"paladox"},"comment":"Patch Set 2:\n\ntest","patchSet":{"number":"2","revision":"80946a8b2581be4fc3e1d368e06505e7575e7e72","parents":["7d3f9dde3c73da5d527349ddf4e916ad9b0b6719"],"ref":"refs/changes/67/67/2","uploader":{"name":"Paladox","email":"thomasmulhall410@yahoo.com","username":"paladox"},"createdOn":1481389892,"author":{"name":"Paladox","email":"thomasmulhall410@yahoo.com","username":"paladox"},"isDraft":false,"kind":"REWORK","sizeInsertions":0,"sizeDeletions":-6},"change":{"project":"mediawiki/extensions/test","branch":"master","id":"I815471a06f2115d52b6a4ed41dcc9f6af04da9ba","number":"67","subject":"Insert the description of the change.","owner":{"name":"Paladox","email":"thomasmulhall410@yahoo.com","username":"paladox"},"url":"https://gerrit.git.wmflabs.org/r/67","commitMessage":"Insert the description of the change.\n\nChange-Id: I815471a06f2115d52b6a4ed41dcc9f6af04da9ba\n","status":"MERGED"},"project":"mediawiki/extensions/test","refName":"refs/heads/master","changeKey":{"id":"I815471a06f2115d52b6a4ed41dcc9f6af04da9ba"},"type":"comment-added","eventCreatedOn":1481657177}

Change 327072 had a related patch set (by Paladox) published:
Fix merged changes comments not being put onto irc

https://gerrit.wikimedia.org/r/327072

Change 327072 merged by jenkins-bot:
Fix merged changes comments not being put onto irc

https://gerrit.wikimedia.org/r/327072

Paladox closed this task as Resolved.Dec 13 2016, 10:06 PM
Paladox claimed this task.