Page MenuHomePhabricator

new HtmlPageLinkRenderer[Begin|End] hooks not documented
Closed, ResolvedPublic



I've here an extension/hack making extensive use of the LinkBegin hook. It seems, reading 1.28 release notes, that it has been deprecated:

... In addition, the LinkBegin and LinkEnd hooks were replaced by HtmlPageLinkRendererBegin and HtmlPageLinkRendererEnd respectively. See docs/hooks.txt for the specific changes needed for those hooks.

But neither the old page tells anything about it, neither the new hook one exists. It seems that some parameter was changed (reading code), and the docs/hooks.txt may be also wrong.

This applies to both LinkBegin and LinkEnd.

Ciao :-)

Event Timeline

stronk7 created this task.Dec 12 2016, 12:35 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptDec 12 2016, 12:35 AM
Superyetkin closed this task as Resolved.May 7 2017, 2:37 PM
Superyetkin claimed this task.
Superyetkin added a subscriber: Superyetkin.

Related wiki page mentions the depracation now. Thanks to VictorPorton for the change.

The mention is ok... but...

... the main goal of this ticket (to get the new HtmlPageLinkRenderer[Begin|End] hooks documented) is just not done yet. Information in the hooks.txt does not seem accurate plus there isn't any documentation about them:

For your consideration, but IMO the documentation status of those is suboptimal.

Thanks and ciao :-)