Page MenuHomePhabricator
Create Task
Maniphest T152946

Editing a section in NWE scrolls to somewhere in the middle of the section
Closed, ResolvedPublic1 Estimated Story Points
Actions

Description

Steps to reproduce:

  1. Enable NWE on https://de.wikipedia.beta.wmflabs.org
  2. Go to https://de.wikipedia.beta.wmflabs.org/wiki/Benutzer_Diskussion:PerfektesChaos#Modul:DateTime
  3. Click "Quelltext bearbeiten" for that section.

Expected result: The source code is visible from start.
Actual result: While loading the editor, the page jumps up (about 1.5 screens), when the source code editor is visible, the content is scrolled up.

Just for the case this is a browser issue: Firefox 49.0.2 on Linux

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Don't restore scroll position when doing real section editing (NWE)mediawiki/extensions/VisualEditormaster+6 -1
Customize query in gerrit

Event Timeline

Schnark created this task.Dec 12 2016, 10:14 AM
Restricted Application added a project: VisualEditor. · View Herald TranscriptDec 12 2016, 10:14 AM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Jdforrester-WMF moved this task from To Triage to TR1: Releases on the VisualEditor board.Dec 12 2016, 7:26 PM
Jdforrester-WMF triaged this task as Medium priority.Dec 12 2016, 7:31 PM
Jdforrester-WMF set the point value for this task to 1.
Schnark added a comment.Dec 13 2016, 8:07 AM

As far as I can see this is caused by hiding the TOC when switching into edit mode. This scrolls the page up (if you are below the TOC). In visual mode the view is repositioned after loading, but not in source mode, causing the content to be scrolled up.

gerritbot subscribed.Dec 13 2016, 3:45 PM

Change 326977 had a related patch set uploaded (by Esanders):
Don't restore scroll position when doing real section editing (NWE)

https://gerrit.wikimedia.org/r/326977

gerritbot added a project: Patch-For-Review.Dec 13 2016, 3:45 PM
Jdforrester-WMF closed this task as Resolved.Dec 13 2016, 4:14 PM
Jdforrester-WMF assigned this task to Esanders.
Jdforrester-WMF removed a project: Patch-For-Review.
gerritbot added a comment.Dec 13 2016, 4:33 PM

Change 326977 merged by jenkins-bot:
Don't restore scroll position when doing real section editing (NWE)

https://gerrit.wikimedia.org/r/326977

ReleaseTaggerBot added a project: MW-1.29-release (WMF-deploy-2016-12-13_(1.29.0-wmf.6)).Dec 13 2016, 5:01 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits