Page MenuHomePhabricator
Create Task
Maniphest T153051

Search page duplicates result
Closed, ResolvedPublic
Actions

Description

Hard to describe, easy to show:

Screen Shot 2016-12-13 at 10.52.20 AM.png (1×2 px, 528 KB)

When only 1 result is present, the same result is duplicated below the heading "Showing results from ..."

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Do not return the current wikis when detecting query languagesmediawiki/extensions/CirrusSearchwmf/1.29.0-wmf.6+38 -3
Do not return the current wikis when detecting query languagesmediawiki/extensions/CirrusSearchmaster+38 -3
Customize query in gerrit

Related Objects

Event Timeline

Jdrewniak created this task.Dec 13 2016, 10:05 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptDec 13 2016, 10:05 AM
dcausse triaged this task as High priority.Dec 13 2016, 12:09 PM
dcausse edited projects, added Discovery-Search (Current work), CirrusSearch; removed Discovery-Search.

Damn, thanks for the report @Jdrewniak, it's probably caused by my refactoring of interwiki searches.
Will add to the backlog as it seems to be a nasty regression.

Restricted Application edited projects, added Discovery-ARCHIVED, Discovery-Search; removed Discovery-Search (Current work). · View Herald TranscriptDec 13 2016, 12:09 PM
dcausse moved this task from needs triage to Current work on the Discovery-Search board.Dec 13 2016, 12:09 PM
dcausse edited projects, added Discovery-Search (Current work); removed Discovery-Search.
dcausse claimed this task.Dec 13 2016, 12:11 PM
dcausse moved this task from Incoming to not in use - please delete on the Discovery-Search (Current work) board.
TJones added a comment.Dec 13 2016, 5:12 PM

@Jdrewniak, thanks for catching this one. I'm glad this one isn't TextCat's fault!

gerritbot subscribed.Dec 13 2016, 7:42 PM

Change 327031 had a related patch set uploaded (by DCausse):
Do not return the current wikis when detecting query languages

https://gerrit.wikimedia.org/r/327031

gerritbot added a project: Patch-For-Review.Dec 13 2016, 7:42 PM
dcausse moved this task from not in use - please delete to Needs review on the Discovery-Search (Current work) board.Dec 13 2016, 7:46 PM
gerritbot added a comment.Dec 15 2016, 1:55 AM

Change 327031 merged by jenkins-bot:
Do not return the current wikis when detecting query languages

https://gerrit.wikimedia.org/r/327031

ReleaseTaggerBot added a project: MW-1.29-release (WMF-deploy-2017-01-03_(1.29.0-wmf.7)).Dec 15 2016, 2:00 AM
Smalyshev moved this task from Needs review to Needs Reporting on the Discovery-Search (Current work) board.Dec 15 2016, 5:47 AM
gerritbot added a comment.Dec 15 2016, 9:42 AM

Change 327467 had a related patch set uploaded (by DCausse):
Do not return the current wikis when detecting query languages

https://gerrit.wikimedia.org/r/327467

Raymond merged a task: T152988: TextCat shows search results from the same wiki.Dec 15 2016, 1:25 PM
Raymond subscribed.
• Deskana closed this task as Resolved.Dec 15 2016, 1:28 PM
gerritbot added a comment.Dec 15 2016, 2:44 PM

Change 327467 merged by jenkins-bot:
Do not return the current wikis when detecting query languages

https://gerrit.wikimedia.org/r/327467

Stashbot subscribed.Dec 15 2016, 2:59 PM

Mentioned in SAL (#wikimedia-operations) [2016-12-15T14:59:01Z] <dcausse@tin> Synchronized php-1.29.0-wmf.6/extensions/CirrusSearch: T153051: Do not return the current wikis when detecting query languages (duration: 00m 52s)

ReleaseTaggerBot added a project: MW-1.29-release (WMF-deploy-2016-12-13_(1.29.0-wmf.6)).Dec 15 2016, 3:00 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits