Page MenuHomePhabricator
Create Task
Maniphest T153100

Fullscreen map not closing properly
Closed, ResolvedPublic
Actions

Description

With a recent commit, the full screen map does not close properly with maplinks.

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Fix fullscreen map not closing properlymediawiki/extensions/Kartographerwmf/1.29.0-wmf.6+1 -0
Fix fullscreen map not closing properlymediawiki/extensions/Kartographermaster+1 -0
Customize query in gerrit

Event Timeline

• JGirault created this task.Dec 13 2016, 5:56 PM
Restricted Application added subscribers: Jay8g, Luke081515, TerraCodes, Aklapper. · View Herald TranscriptDec 13 2016, 5:56 PM
gerritbot subscribed.Dec 13 2016, 5:58 PM

Change 327012 had a related patch set uploaded (by JGirault):
Fix fullscreen map not closing properly

https://gerrit.wikimedia.org/r/327012

gerritbot added a project: Patch-For-Review.Dec 13 2016, 5:58 PM
• JGirault moved this task from Backlog to Needs review on the Maps-Sprint board.Dec 13 2016, 5:58 PM
gerritbot added a comment.Dec 13 2016, 8:43 PM

Change 327012 merged by jenkins-bot:
Fix fullscreen map not closing properly

https://gerrit.wikimedia.org/r/327012

ReleaseTaggerBot added a project: MW-1.29-release (WMF-deploy-2017-01-03_(1.29.0-wmf.7)).Dec 13 2016, 9:00 PM
• JGirault moved this task from Needs review to Done on the Maps-Sprint board.Dec 15 2016, 12:06 AM
gerritbot added a comment.Dec 15 2016, 2:27 AM

Change 327423 had a related patch set uploaded (by Yurik):
Fix fullscreen map not closing properly

https://gerrit.wikimedia.org/r/327423

gerritbot added a comment.Dec 15 2016, 1:57 PM

Change 327423 merged by jenkins-bot:
Fix fullscreen map not closing properly

https://gerrit.wikimedia.org/r/327423

ReleaseTaggerBot added a project: MW-1.29-release (WMF-deploy-2016-12-13_(1.29.0-wmf.6)).Dec 15 2016, 2:00 PM
Stashbot subscribed.Dec 15 2016, 2:28 PM

Mentioned in SAL (#wikimedia-operations) [2016-12-15T14:28:53Z] <zfilipin@tin> Synchronized php-1.29.0-wmf.6/extensions/Kartographer: SWAT: [[gerrit:327423|Fix fullscreen map not closing properly (T153100)]] (duration: 00m 40s)

• demon subscribed.Dec 16 2016, 5:10 PM

Is this resolved now?

Yurik added subscribers: • debt, Yurik.Dec 16 2016, 5:26 PM

@demon yep, waiting for @debt

• debt closed this task as Resolved.Dec 16 2016, 6:04 PM

Hi @demon - we recently added a 'done' column to this board, so that we can easily tell which items have been recently pushed into production and can be verified before resolving. This ticket was pushed into production yesterday, which did fix the issue of the X not closing the map, so, resolving.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits