The PHP implementation of TextCat has some of the features (switches -a, -u; var $top and $max) in the runner script rather than the main module, and should be moved so ambiguity detection happens inside TextCat proper.
The Perl version also has some additional command line features the PHP version lacks, Those should be added to the PHP version, too.
Also need to double check that the Cirrus calls to TextCat will be correct after the refactor.
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| Move ambiguity detection into main TextCat module. | wikimedia/textcat | master | +310 -76 |
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Open | None | T118278 [EPIC] Improve Language Identification for use in Cirrus Search | |||
| Resolved | TJones | T140289 Investigate Improvements and Confidence Measures for TextCat Language Detection | |||
| Resolved | TJones | T153105 Refactor TextCat for ambiguity detection and add additional params |
Change 327364 had a related patch set uploaded (by Tjones):
Move ambiguity detection into main TextCat module.
Change 327364 merged by jenkins-bot:
Move ambiguity detection into main TextCat module.